Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp]gd32 uart support dma #7694

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JasonCang
Copy link
Contributor

@JasonCang JasonCang commented Jun 17, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

gd32 uart support dma tx and rx

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

all
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Guozhanxin
Copy link
Member

看下ci错误
image

@mysterywolf
Copy link
Member

代码格式有问题 请用formatting格式化一下 https://github.com/mysterywolf/formatting

@Guozhanxin Guozhanxin added the reviewed PR has been reviewed. label Jun 19, 2023
@JasonCang
Copy link
Contributor Author

代码格式有问题 请用formatting格式化一下 https://github.com/mysterywolf/formatting

已修复

@JasonCang
Copy link
Contributor Author

看下ci错误 image

已针对F4修改了sconscript文件,编译成功,F1-3官方库版本差异太大。

@mysterywolf
Copy link
Member

CI依然不过 请麻烦确认一下

@supperthomas
Copy link
Member

error: unknown type name 'dma_subperipheral_enum' 看下这个定义在哪里

@Guozhanxin
Copy link
Member

看下ci错误 image

已针对F4修改了sconscript文件,编译成功,F1-3官方库版本差异太大。

@JasonCang 如果其他系列的bsp不支持dma的话,需要在驱动里加些宏控制。防止其他的bsp编译报错

@JasonCang
Copy link
Contributor Author

看下ci错误 image

已针对F4修改了sconscript文件,编译成功,F1-3官方库版本差异太大。

@JasonCang 如果其他系列的bsp不支持dma的话,需要在驱动里加些宏控制。防止其他的bsp编译报错

本地有什么工具可以测试吗?每次提交git太浪费时间了。我想本地编译没问题了再提交

@JasonCang
Copy link
Contributor Author

CI依然不过 请麻烦确认一下

其他bsp不支持,本地有工具可以自动测试CI吗?不想每次都提交git再测试

@supperthomas
Copy link
Member

@supperthomas
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed PR has been reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants