-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microchip SAM series MCU support for RT-Thread #5771
Conversation
Add Microchip SAM series MCU support for RT-Thread, including SAM Cortex-M0+, M4F and M7.
There are many File format errors, such as: |
如果是半导体厂商提供的库,不需要格式化代码 可以参照此处来让ci排除格式检查,增加这个文件机器人就不会检查格式问题了 https://github.com/RT-Thread/rt-thread/blob/master/bsp/acm32/acm32f0x0-nucleo/.ignore_format.yml 如果是给rtt适配的驱动,是需要整理格式的,请使用这个脚本来进行扫描:https://github.com/mysterywolf/formatting 感谢提交pr |
也请将新增加的bsp 加入到机器人自检队列中: |
https://github.com/RT-Thread/rt-thread/tree/master/components/libc/compilers 你只需要实现我们这侧的console设备也就是将串口设备实现好,并将console设备指定到该串口设备,就可以直接使用printf putc, read(FILENO_STDIN) write(FILENO_STDOUT)这类基本的输入输出了。如果对接了文件系统,就可以直接用read write来读写文件了。 |
Add bsp directory to ignored check list, add microchip /samc21/same54/same70 to workflows list
1. remove STDIO code from Microchip official BSP. 2. bug fix of SAME70 hpl/hpl_usart.c, samc21&same54 hpl/hpl_sercom.c baudrate update interface. 3. Add RT-Thread standard STDIO implementation on Microchip SAM MCU.
已经添加
已经添加,开发者的代码已经通过工具扫描
已经移除Microchip官方STDIO实现的代码,添加RT-Thread console设备在Microchip SAM MCU上的实现。 |
@Guozhanxin 郭老师 帮忙看一下 是不是CI没有安装gcc10的工具链? |
@mysterywolf 请问有什么建议解决后台编译出错的问题?我这边用env tools工具测试都是没问题的。 |
感谢提交代码,您的几份bsp rtconfig.py文件都还存在些问题: 例如 LFLAGS = DEVICE + ' -Wl,--gc-sections,-Map=rtthread.map,-cref, -T bsp/samc21/gcc/gcc/samc21j18a_flash.ld'
LFLAGS = DEVICE + ' -Wl,--gc-sections,-Map=rtthread.map,-cref,-T bsp/samc21/gcc/gcc/samc21j18a_flash.ld' |
@BernardXiong 感谢指正,我修正rtconfig.py脚本后再提交 |
Add CAN driver and example for SAMC21/SAME5x/SAME70 and fix rtconfig.py issue(unused space might result link error)
关于README.md文档中,中文相关的是缺少的,但是存在中文的链接。 |
Add Chinese version README for SAMC21/E54/E70
已经添加 |
@Guozhanxin 郭老师麻烦再批准一下ci流程 |
这些文件对于本bsp来说是无意义的,如果每个bsp都上传一些无意义的文件的话,rtt的仓库就会变成垃圾堆了😂 |
这样 你先把Makefile都干掉吧 CMSIS的部分可以先留着,后续我们统一处理一下,不止这一个bsp有这个问题。但是Makefile文件要都删掉,否则可能和我们自己生成的Makefile工程产生冲突。 |
Remove Makefile to avoid conflict with rt and add directory description.
@Guozhanxin 郭老师这个PR我没有问题了,请批准CI流程,并review一下。 |
Remove unwanted content in README.md
Add Microchip SAM series MCU support for RT-Thread, including SAM Cortex-M0+, M4F and M7.
拉取/合并请求描述:(PR description)
[
Add Microchip SAM series MCU support for RT-Thread.
Pull request has verified on Microchip SAMC21-Xplained demo board, SAME54-Xplained demo board and SAME70-XULT demo board, see microchip\readme.MD for more details. The verification including using env tools to compile code, using menuconfig on env tools to generate RT configuration header file and code debug test with Microchip IDE.
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up