Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lwip] integrate lwip porting layer #5606

Merged
merged 9 commits into from
Feb 23, 2022
Merged

[lwip] integrate lwip porting layer #5606

merged 9 commits into from
Feb 23, 2022

Conversation

mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented Feb 21, 2022 •
edited
Loading

拉取/合并请求描述：(PR description)

[
本PR由 @xiangxistu 和 @mysterywolf 共同完成

https://github.com/mysterywolf/rt-thread/tree/lwip%3Dport/components/net/lwip/port

以下内容为贤良在 mysterywolf#2 中的comment：
已经在 stm32f407-atk-explorer 上测试通过。

705c9faf702afa31ea7bda0144a12c9
8898067588b8a50755be980d4c580fc
a1bfb2df85ad5f8483d5c62c6eb54a6

注意

仍然存在的问题：

  • lwip-1.4.1 上的 ping 问题未修复，上个版本也有类似问题，该问题与此次 PR 无关。

    • lwip-1.4.1 上的异常情况
      6a98aa12c1bccb55543220a0ba77dbf
    • lwip-2.0.3 上的正常情况
      3d74dce4a976569a792d1334e5e9fb1
      所有报文都能发出<发出错误报文也是发出，判断不是协议栈不运行的问题>；ICMP 报文能正常收发，ping lwip1.4.1 所在的 IP
      地址也能收到回复，但是 ping 出时无法接收到回复。该问题与 dst 地址在报文中填写错误有关， DNS 服务正常，UDP 服务正常， TCP 客户端， TCP服务器测试正常。

  • TCP 重发次数过多
    【逻辑正常，能连接，发送，接收，但有多次数据包重发的问题】

以上问题不属于本次 PR 的解决内容，会有后续 PR 处理该问题。

已经修改的问题：

  • lwip1.4.1 的 netif->flags 问题
    在以前的版本中，flags 定义不准确，netdev.h 与 netif.h 中的 flags 宏冲突。现已经修改正常。

]

以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf added the in progress PR/issue in progress. label Feb 21, 2022
mysterywolf and others added 2 commits February 21, 2022 18:52
@mysterywolf
[lwip] integrate lwip porting layer
8008b2e
@xiangxistu
Lwip 通用文件梳理 (#2)
435d86f 
* [modify] extract the common files for different version about lwip.

* [update] the initialization logic of lwIP.
@mysterywolf mysterywolf removed the in progress PR/issue in progress. label Feb 22, 2022
@mysterywolf mysterywolf mentioned this pull request Feb 22, 2022
Closed
24 tasks
@mysterywolf mysterywolf added the in progress PR/issue in progress. label Feb 22, 2022
@BernardXiong BernardXiong marked this pull request as draft February 23, 2022 02:19
@mysterywolf mysterywolf marked this pull request as ready for review February 23, 2022 03:46
@mysterywolf mysterywolf removed the in progress PR/issue in progress. label Feb 23, 2022
@mysterywolf
Copy link
Member Author

mysterywolf commented Feb 23, 2022 •
edited
Loading

This PR is ready to review!
@Guozhanxin @BernardXiong 这份PR可以来Review了
请注意，采用squash方式合并

@Guozhanxin Guozhanxin added the +1 Agree +1 label Feb 23, 2022
@Guozhanxin
Copy link
Member

测试了下，没问题

@BernardXiong BernardXiong merged commit e96e3e0 into RT-Thread:master Feb 23, 2022
@mysterywolf mysterywolf deleted the lwip=port branch February 23, 2022 21:09
QIANWC pushed a commit to QIANWC/rt-thread that referenced this pull request Feb 24, 2022
@mysterywolf @xiangxistu @QIANWC
[lwip] integrate lwip porting layer (RT-Thread#5606)
8f41447 
* [lwip] integrate lwip porting layer

* Lwip 通用文件梳理 (RT-Thread#2)

* [modify] extract the common files for different version about lwip.

* [update] the initialization logic of lwIP.

* 整理源码结构

* ethernetif 头文件 ""改为<>

* 整理代码

* add macro definition "RT_USING_DEVICE_IPC".

* [update] mandatory selected "RT_USING_DEVICE_IPC".

* [modify] compile error for lost "lwip/init.h"

Co-authored-by: xiangxistu <[email protected]>
Co-authored-by: liuxianliang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guozhanxin Guozhanxin Guozhanxin approved these changes

@BernardXiong BernardXiong Awaiting requested review from BernardXiong

Assignees
No one assigned
Labels
important +1 Agree +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mysterywolf @Guozhanxin @BernardXiong @xiangxistu