Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building error in bsp/mini2440 (Issue #26) #28

Closed
wants to merge 1 commit into from

Conversation

rogerz
Copy link
Member

@rogerz rogerz commented Feb 3, 2013

Please check the correction if possible, @grissiom, @BernardXiong.

I'm not very clear about the architecture in RTGUI, neither do I have the a test environment.

@grissiom
Copy link
Member

grissiom commented Feb 5, 2013

Yes, the fix is right.

But I have been thinking that move all the calibration.c in BSPs into RTGUI. This will result in less duplicate code and less work for BSPs. Is that possible?

@yqiu2018
Copy link
Member

yqiu2018 commented Feb 5, 2013

I think it is reasonable.

2013/2/5 Grissiom.GuRui [email protected]

Yes, the fix is right.

But I have been thinking that move all the calibration.c in BSPs into
RTGUI. This will result in less duplicate code and less work for BSPs. Is
that possible?


Reply to this email directly or view it on GitHubhttps://github.com//pull/28#issuecomment-13116715.

@rogerz
Copy link
Member Author

rogerz commented Feb 19, 2013

It seems the correction @grissiom suggested won't be complete in a short time.

Is it OK to accept this pull request first? At least it will make travis-ci happy.

@grissiom
Copy link
Member

OK. I left my st-link in the lab so I cannot run/debug on the board instantly.

I will fix this and send a new pull request in this weekend.

@BernardXiong
Copy link
Member

There is no RT-Thread/GUI in default, therefore, there is no this issue. And another, I just remove the calibration.c file.

@rogerz rogerz deleted the build-error branch February 22, 2013 14:25
BernardXiong pushed a commit that referenced this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants