Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support private fields in header #8

Merged
merged 6 commits into from
Mar 20, 2022
Merged

Support private fields in header #8

merged 6 commits into from
Mar 20, 2022

Conversation

elazarcoh
Copy link
Collaborator

No description provided.

jond01
jond01 reviewed Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@jond01 jond01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍
I had two comments.
Can you please exclude PR #7 commits from this PR? It will be easier to review

Links for myself:

pyproject.toml Outdated Show resolved Hide resolved
medio/backends/itk_io.py Outdated Show resolved Hide resolved
@elazarcoh elazarcoh force-pushed the elazarcoh/issue5 branch 2 times, most recently from ab273f7 to a3d6e4e Compare February 16, 2022 06:37
@elazarcoh elazarcoh linked an issue Feb 28, 2022 that may be closed by this pull request
Support private fields in header #5
Closed
@elazarcoh
Copy link
Collaborator Author

I'm not sure why the read_dir and read_img_file are separated. We can use itk.imread for both.
I'm not going to change that for now, though. It might break something that I'm not aware of.

jond01
jond01 approved these changes Mar 5, 2022
View reviewed changes
medio/backends/itk_io.py Outdated Show resolved Hide resolved
medio/backends/itk_io.py Outdated Show resolved Hide resolved
jond01
jond01 requested changes Mar 5, 2022
View reviewed changes
medio/backends/itk_io.py Outdated Show resolved Hide resolved
@elazarcoh elazarcoh requested a review from jond01 March 13, 2022 05:30
jond01
jond01 requested changes Mar 13, 2022
View reviewed changes
medio/backends/itk_io.py Outdated Show resolved Hide resolved
medio/backends/itk_io.py Outdated Show resolved Hide resolved
@elazarcoh elazarcoh requested a review from jond01 March 14, 2022 08:08
jond01
jond01 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@jond01 jond01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one last comment.

That's a significant enhancement, thanks!

medio/backends/itk_io.py Outdated Show resolved Hide resolved
@elazarcoh elazarcoh requested a review from jond01 March 15, 2022 09:30
@elazarcoh elazarcoh merged commit 68a025a into master Mar 20, 2022
@elazarcoh elazarcoh deleted the elazarcoh/issue5 branch March 20, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jond01 jond01 jond01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support private fields in header
2 participants
@elazarcoh @jond01