Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version import #3

Merged
2 commits merged into from
Jun 24, 2021
Merged

Fix version import #3

2 commits merged into from
Jun 24, 2021

Conversation

jond01
Copy link
Collaborator

@jond01 jond01 commented Jun 23, 2021

Currently, building the package from source with
pip install -e path/to/medio/
fails as __init__.py imports some packages that are not yet installed.
This PR fixes this issue.

@jond01 jond01 requested a review from a user June 23, 2021 05:23
@ghost
Copy link

ghost commented Jun 24, 2021

OK.

Note that I'm in the middle of the process of adapting to pyproject.toml, which make this change (well, the setup.py file) redundant in the future, when pip will support --editable for pyproject.toml projects. Not sure where it currently stands

@ghost ghost merged commit bb2538f into RSIP-Vision:master Jun 24, 2021
@jond01 jond01 deleted the fix-version-import branch June 24, 2021 05:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant