Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellSaveData: Add autosave indicator #15720

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NicknineTheEagle
Copy link
Contributor

This adds standard autosave and autoload indicators that would appear on PS3 when the game requests them. Since RPCS3 saves basically instantaneously, this auto indicator simply appears for a few seconds to let the user known when the game autosaves.

@jeremybris

This comment was marked as resolved.

@elad335
Copy link
Contributor

elad335 commented Jun 22, 2024

"Closing while saving may cause damage to your save. Are you sure you want to close the emulator?" - "Yes / No"

It's not relevant for RPCS3, our saves are superior.

@Megamouse Megamouse added Savedata Anything that involves cellSaveData Overlay Firmware: HLE labels Jun 22, 2024
y_offset += (spacing + it->h);
}
else
else if (origin == message_pin_location::bottom)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a switch

case CELL_SAVEDATA_INDICATORPOS_LOWER_RIGHT:
msg_location = rsx::overlays::message_pin_location::bottom_right;
break;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing default

msg_text = localized_string_id::CELL_SAVEDATA_AUTOLOAD;
}

u32 indicator_pos = (statSet->indicator->dispPosition & 0x0F);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
u32 indicator_pos = (statSet->indicator->dispPosition & 0x0F);
const u32 indicator_pos = (statSet->indicator->dispPosition & 0x0F);

@elad335
Copy link
Contributor

elad335 commented Jun 28, 2024

Was testing something / not intended for merge yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firmware: HLE Overlay Savedata Anything that involves cellSaveData
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants