-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating DEB and RPM files with the source from the rocm-examples. #143
Conversation
@dgaliffiAMD I tested the deb file generated from my There are some issues with the rpm file generation in my script, so I will continue working on fixing those issues. |
The rpm file generation also seems to be working, you can view file contents of the rpm file generated from |
@dgaliffiAMD PR is ready for review! :) |
…ting due to missing build ID
Signed-off-by: David Galiffi <[email protected]>
…OCm/rocm-examples into generate-deb-and-rpm-files-with-source
To match casing of the other subfolders Signed-off-by: David Galiffi <[email protected]>
Also, this is probably out of the scope of this PR, but AFAIK a GitHub action could be set up to build the packages and add them to the "Releases" section of the repo when, for instance, a release tagged branch # Release workflow file
on:
push:
tags:
- 'rocm-*'
jobs:
package:
steps:
- name: Build packages
run: Scripts/Package/build_packages.sh
- name: Release packages
uses: softprops/action-gh-release@v1
with:
draft: true
files: /path/to/generated/packages |
…fine PACKAGE_HOMEPAGE_URL variable for consistency in DEB and RPM packages.
PACKAGE_VERSION, PACKAGE_INSTALL_PREFIX, BUILD_DIR as arguments and add default values
Signed-off-by: David Galiffi <[email protected]>
I'm not seeing the install prefix on the generated DEB file anymore. Everything is being installed directly to |
Using the "cat EOF" to create DEBIAN/control, rather than multiple "echo" statments. Similar to how the RPM spec files is generated.
Use "STAGING_DIR" constant rather than input parameter to helper functions. This matches the style of other constants being used, like BUILD_DIR and SOURCE_DIR
Useful for build logs.
Artifacts can be used for debugging.
Adds a script to automate the packaging of ROCm SDK examples into DEB and RPM packages. The script performs the following tasks: