Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests according to latest compiler changes #142

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jtpatel
Copy link
Contributor

@jtpatel jtpatel commented Jul 16, 2024

Fix tests according to latest compiler changes

@dgaliffiAMD dgaliffiAMD changed the title SWDEV-468634 - Fix tests according to latest compiler changes Fix tests according to latest compiler changes Jul 19, 2024
@dgaliffiAMD
Copy link
Collaborator

Renaming to remove reference to internal ticket, SWDEV-468634. You can include this in the message body when it's time to "Squash and Merge".
As I understand, while this will fix compilation on rocm-6.2, it will break rocm-6.1. Is there a way to keep the develop branch compiling on both rocm-6.1 and rocm-6.2? For example, a pre-procesing variable to check?

Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that rocm-6.2 has been released, let's merge this change.

@dgaliffiAMD dgaliffiAMD merged commit 4a15db3 into ROCm:develop Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants