Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nvcc_detail/hip_runtime_api.h C compliant #49

Closed
wants to merge 1 commit into from

Conversation

NEELMCW
Copy link

@NEELMCW NEELMCW commented Nov 18, 2016

This commit adds #ifdef control statements to make the header C compliant
In C++, member type declaration and setting default parameters to function arguments are possible
which may not be case with C. So appropriate #ifdefs and else are added to accomodate C compliance

This commit adds #ifdef control statements to make the header C compliant
In C++, member type declaration and setting default parameters to function arguments are possible
which may not be case with C. So appropriate #ifdefs and else are added to accomodate C compliance
@NEELMCW
Copy link
Author

NEELMCW commented Nov 18, 2016

The indentation of the code might be slightly off. I would like to know the coding guidelines that HIP team is following to ensure uniformity. I happen to see tabs in certain places and spaces in other.

@bensander
Copy link
Contributor

Hi Neel – coding convention specifies spaces. Sounds like we need to do a little housecleaning.
-ben

From: NEELMCW [email protected]
Reply-To: GPUOpen-ProfessionalCompute-Tools/HIP [email protected]
Date: Friday, November 18, 2016 at 4:11 AM
To: GPUOpen-ProfessionalCompute-Tools/HIP [email protected]
Subject: Re: [GPUOpen-ProfessionalCompute-Tools/HIP] Make nvcc_detail/hip_runtime_api.h C compliant (#49)

The indentation of the code might be slightly off. I would like to know the coding guidelines that HIP team is following to ensure uniformity. I happen to see tabs in certain places and spaces in other.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/49#issuecomment-261495643, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACYSAsLzIEXN3TVX-N_vqqGzJeyYbCc3ks5q_XnbgaJpZM4K2Tul.

@aditya4d1
Copy link
Contributor

Hi @NEELMCW ,
Can you test developer preview branch and create pull request based off it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants