Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix surface functions #3518

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix surface functions #3518

merged 1 commit into from
Jul 23, 2024

Conversation

matyas-streamhpc
Copy link

@matyas-streamhpc matyas-streamhpc commented Jun 7, 2024 •
edited by neon60

@matyas-streamhpc matyas-streamhpc force-pushed the fix-surface-functions branch 6 times, most recently from 7f66322 to 7b5e1be Compare June 7, 2024 07:37
@matyas-streamhpc matyas-streamhpc marked this pull request as draft June 7, 2024 07:45
@matyas-streamhpc matyas-streamhpc self-assigned this Jun 7, 2024
@neon60 neon60 requested review from samjwu and yhuiYH and removed request for mangupta, gandryey and rakesroy June 7, 2024 08:08
@neon60 neon60 marked this pull request as ready for review June 11, 2024 08:37
@neon60 neon60 requested a review from lpaoletti June 16, 2024 18:58
lpaoletti
lpaoletti reviewed Jun 27, 2024
View reviewed changes
Copy link

@lpaoletti lpaoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notice the file is named kernel_language.rst.
that doesn't line up with the document title: C++ Language Extensions

Lining up the file name and title improves searchability.

@matyas-streamhpc
Copy link
Author

matyas-streamhpc commented Jun 28, 2024 •
edited

notice the file is named kernel_language.rst. that doesn't line up with the document title: C++ Language Extensions

Lining up the file name and title improves searchability.

I am opening a new PR to fix it:
#3534

@matyas-streamhpc matyas-streamhpc force-pushed the fix-surface-functions branch 2 times, most recently from fb208a7 to aacbe6c Compare June 28, 2024 09:44
@neon60 neon60 force-pushed the fix-surface-functions branch 2 times, most recently from 5eba689 to c3eddbe Compare July 11, 2024 07:19
@neon60 neon60 force-pushed the fix-surface-functions branch 3 times, most recently from 8062f25 to cda724c Compare July 22, 2024 19:42
@neon60
Fix surface functions
4571f74 
Update surface functions in cpp language extensions
Update doxyfile and fix the function naming
Change to new clr branch
Fix white space characthers
@neon60
Copy link
Contributor

neon60 commented Jul 23, 2024

Got approval. Merging to docs/develop.

@neon60 neon60 merged commit 4c860aa into docs/develop Jul 23, 2024
4 checks passed
@neon60 neon60 deleted the fix-surface-functions branch July 24, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpaoletti lpaoletti lpaoletti approved these changes

@samjwu samjwu Awaiting requested review from samjwu

@yhuiYH yhuiYH Awaiting requested review from yhuiYH

Assignees

@matyas-streamhpc matyas-streamhpc

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matyas-streamhpc @neon60 @lpaoletti