Add reduction tutorial #3513
Open
Add reduction tutorial #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpaoletti
reviewed
Jun 10, 2024
lpaoletti
reviewed
Jun 10, 2024
lpaoletti
reviewed
Jun 10, 2024
neon60
force-pushed
the
reduction_tutorial
branch
from
7330c2e
to
1e6f150
Compare
neon60
force-pushed
the
reduction_tutorial
branch
from
7a2c617
to
ed9e01e
Compare
SwRaw
reviewed
Jun 14, 2024
SwRaw
reviewed
Jun 17, 2024
SwRaw
reviewed
Jun 17, 2024
SwRaw
reviewed
Jun 17, 2024
SwRaw
reviewed
Jun 17, 2024
neon60
force-pushed
the
reduction_tutorial
branch
2 times, most recently
from
5e1ee17
to
33401d5
Compare
neon60
force-pushed
the
reduction_tutorial
branch
from
0c1df1c
to
69a43be
Compare
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
| Two-pass reduction | ||
| ------------------ | ||
|
|
||
| Alter kernel launch and input fetching such that no more blocks are launched than what a subsequent kernel launch's single block can conveniently reduce, while performing multiple passes of input reading from global and combining their results before engaging in the end game tree-like reduction. |
There was a problem hiding this comment.
Something is off in this sentence. I can't quite understand it. Difficult to comment.
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
|
|
||
| This modification can only be executed on AMD hardware. | ||
|
|
||
| Perform the first step of the two-pass reduction, but in the end, instead of writing to global and reading it back in a subsequent kernel, write the partial results to the Global Data Share (GDS). This is an ``N+1`` th shared memory that is accessed by all multiprocessors and is also on-chip memory. |
There was a problem hiding this comment.
Suggested change
| Perform the first step of the two-pass reduction, but in the end, instead of writing to global and reading it back in a subsequent kernel, write the partial results to the Global Data Share (GDS). This is an ``N+1`` th shared memory that is accessed by all multiprocessors and is also on-chip memory. | |
| Perform the first step of the two-pass reduction, but in the end, instead of writing to global and reading it back in a subsequent kernel, write the partial results to the Global Data Share (GDS). This is an ``N+1`` **th** shared memory that is accessed by all multiprocessors and is also on-chip memory. |
There was a problem hiding this comment.
I would not make it bold. The problem: https://www.reddit.com/r/math/comments/nw5lb1/n1st_or_n1th/
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
lpaoletti
reviewed
Jun 25, 2024
gandryey
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Do you think it's better to show the numbers in the squares on the third row ? Instead of f(z, 5) it should be 5 and f(13, 8) should be 13
There was a problem hiding this comment.
@gandryey I will be able to check this tonight. If you have more comments, please share.
There was a problem hiding this comment.
Should we show the numbers in the squares, since the full function is already written on the previous step? f(z,5) should be 5 and f(f(z,5),13) should be just 13.
neon60
force-pushed
the
reduction_tutorial
branch
from
b213598
to
5b2f633
Compare
Co-authored-by: Leo Paoletti <[email protected]>
Co-authored-by: Leo Paoletti <[email protected]>
Co-authored-by: Leo Paoletti <[email protected]>
neon60
force-pushed
the
reduction_tutorial
branch
from
5b2f633
to
9707ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reduction tutorial