Performance guideline missing changes #3483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neon60
changed the title
neon60
force-pushed
the
performance-guidelines
branch
2 times, most recently
from
4cb7142
to
f5de18d
Compare
neon60
force-pushed
the
performance-guidelines
branch
from
f5de18d
to
f34da4d
Compare
neon60
force-pushed
the
performance-guidelines
branch
2 times, most recently
from
424cd9e
to
d83ac29
Compare
neon60
force-pushed
the
performance-guidelines
branch
from
d83ac29
to
ebce0c3
Compare
neon60
force-pushed
the
performance-guidelines
branch
from
ebce0c3
to
99817d4
Compare
neon60
force-pushed
the
performance-guidelines
branch
from
99817d4
to
da12e15
Compare
neon60
force-pushed
the
performance-guidelines
branch
from
da12e15
to
e49becd
Compare
neon60
force-pushed
the
performance-guidelines
branch
from
e49becd
to
7b52769
Compare
neon60
force-pushed
the
performance-guidelines
branch
from
7b52769
to
acf0afc
Compare
SwRaw
reviewed
Jul 17, 2024
Co-authored-by: srawat <[email protected]>
Co-authored-by: srawat <[email protected]>
neon60
force-pushed
the
performance-guidelines
branch
from
cb3e7dc
to
02d4255
Compare
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
SwRaw
reviewed
Jul 18, 2024
Co-authored-by: srawat <[email protected]>
neon60
force-pushed
the
performance-guidelines
branch
from
baef337
to
baa65da
Compare
SwRaw
reviewed
Jul 19, 2024
Comment on lines
+78
to
+82
| 1. Each thread of a block loading data from device memory to shared memory. | ||
| 2. Synchronizing with all other threads of the block. | ||
| 3. Processing the data stored in shared memory. | ||
| 4. Synchronizing again if necessary. | ||
| 5. Writing the results back to the device global memory. |
There was a problem hiding this comment.
This numbered list doesn't seem to be rendered well. Could you please check this out. It looks like a list with numbers but not a numbered list.
There was a problem hiding this comment.
For me, this is rendered:
Co-authored-by: srawat <[email protected]>
SwRaw
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.