Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cooperative groups #3478

Open
wants to merge 63 commits into
base: docs/develop
Choose a base branch
from
Open

Add cooperative groups #3478

wants to merge 63 commits into from

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented May 8, 2024 •
edited

Add cooperative groups documentation which contains:

  • Reference
  • How to
  • Tutorial

@neon60 neon60 changed the title Add cooperative groups WIP - Add cooperative groups May 8, 2024
@neon60 neon60 marked this pull request as draft May 8, 2024 15:04
@neon60 neon60 force-pushed the cooperative_groups branch 3 times, most recently from a4b794e to 27d3e89 Compare May 13, 2024 13:04
@neon60 neon60 changed the title WIP - Add cooperative groups Add cooperative groups May 13, 2024
@neon60 neon60 marked this pull request as ready for review May 13, 2024 13:05
randyh62
randyh62 reviewed May 13, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have two files in the docs folder named the same, such as how-to/cooperative_groups.rst and reference/cooperative_groups.rst, even though they are currently in separate folders.

I think one should be renamed.

@neon60 neon60 changed the base branch from develop to docs/develop May 14, 2024 15:13
@neon60
Copy link
Contributor Author

neon60 commented May 14, 2024

I don't think we should have two files in the docs folder named the same, such as how-to/cooperative_groups.rst and reference/cooperative_groups.rst, even though they are currently in separate folders.

I think one should be renamed.

Renamed.

neon60 and others added 29 commits June 20, 2024 18:43
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
af151d9 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/how-to/cooperative_groups.rst
5d1b060 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
e386a3c 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
cbde6d7 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
19bbb10 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/how-to/cooperative_groups.rst
c23ae24 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
400c9f3 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
c2945a7 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
0b8cdf4 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/how-to/cooperative_groups.rst
c0cf0e2 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
430b362 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
542f1ee 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
bca7387 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
b268663 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
11cd40d 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
8b50649 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
4312902 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/how-to/cooperative_groups.rst
12b0cff 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/how-to/cooperative_groups.rst
4769a36 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/tutorials/cooperative_groups_tutorial.rst
797fe81 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60 @lpaoletti
Update docs/how-to/cooperative_groups.rst
928f938 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60
PR feedbacks
44a826c
@neon60
fixes
6426bef
@neon60
fix
5ba8dbb
@neon60
Added cooperative groups tutorial
4f24dbc
@neon60 @lpaoletti
Update docs/how-to/cooperative_groups.rst
732e0af 
Co-authored-by: Leo Paoletti <[email protected]>
@neon60
Clean up
547f9db
@neon60
Update the simple example
94cf72a
@neon60
Whitespace and grammar fix.
204a3e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randyh62 randyh62 randyh62 left review comments

@matyas-streamhpc matyas-streamhpc matyas-streamhpc left review comments

@parbenc parbenc parbenc approved these changes

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

@lpaoletti lpaoletti Awaiting requested review from lpaoletti

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neon60 @randyh62 @matyas-streamhpc @parbenc @lpaoletti