Fix HIT.cmake
handling of no architectures found
#3206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to install HIP on a system without any devices available (such as a login node without GPUs on a cluster) the CMake configuration fails in
HIT.cmake
like this:This is building HIP through spack (I can provide instructions to reproduce this if needed).
This PR fixes the call to
string(REPLACE ...)
to properly quoteHIP_GPU_ARCH
so that the call doesn't fail. Alternatively, or additionally, you could probably do something with the non-zero exit code ofrocm_agent_enumerator
, but I don't know if it can have a non-zero exit code but still list some architectures? So I haven't changed anything regarding that.As a flyby this fixes some typos of "Enumurator".