Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various doxygen documentation fixes #3193

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Maetveis
Copy link
Contributor

@saadrahim saadrahim closed this Mar 30, 2023
@saadrahim saadrahim reopened this Mar 30, 2023
@@ -202,14 +200,12 @@ typedef struct hipPointerAttribute_t {
#define __HIP_NODISCARD
#endif

// Developer note - when updating these, update the hipErrorName and hipErrorString functions in
// NVCC and HCC paths Also update the hipCUDAErrorTohipError function in NVCC path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HCC should not be used.

@gargrahul
Copy link
Contributor

@Maetveis Please rebase this change on latest develop branch.

chrispaquot
chrispaquot previously approved these changes Jun 6, 2023
saadrahim
saadrahim previously approved these changes Jun 9, 2023
Copy link
Member

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gargrahul can you help merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants