EXSWHTEC-83 - Implement new and reimplement existing tests for hipMemAdvise #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
music-dino
commented
Oct 17, 2022
•
music-dino
commented
- Negative parameter tests
- Validate that setting and resetting of flags works as expected
- Validate that setting one flag does not lead to the resetting of another
- Validate round down for base address and roundup for base address + count behavior
- Validate that memory can still be read and write after applying each advice
- Validate that prefetching after setting flags does not interfere with them.
…mmonly useful utility functions and kernels
…e supports any number of attributes
…ode corectness touchups
… for handling pitched memory
chrispaquot
previously approved these changes
Oct 27, 2022
mangupta
previously approved these changes
Nov 3, 2022
|
@music-dino : Some tests fail on CI. Details shared separately. |
mangupta
added
pr:ready_for_ci
chrispaquot
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.