Fix signed vs unsigned comparisons

[fwyzard]

Compiling with gcc 11.4 with -Werror=sign-compare fails with

detail/intrinsics.hpp:218:34: error: comparison of integer expressions of different signedness: ‘const unsigned int’ and ‘int32_t’ {aka ‘int’} [-Werror=sign-compare]
  218 |                 (src < 0 || sidx >= w) ? x : Tile::scratchpad<T>()[sidx]};
      |                             ~~~~~^~~~

[AlexVlx]

Thank you for this! Overall it looks good but a minor nit is that I'd keep uniform (unicorn) initialisation for symmetry i.e. just drop the static_cast inside the curly braces.

[fwyzard]

Do you mean

const auto sidx{static_cast<std::int32_t>((tidx / w * w) + src)};

?

Or

const std::int32_t sidx{(tidx / w * w) + src};

?

[AlexVlx]

const auto sidx{static_cast<std::int32_t>((tidx / w * w) + src)};

Preferably this please. Thank you.

[fwyzard]

Done 👍🏻