-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
board/arduino-leonardo: add initial support (without usb cdc) #7306
Conversation
Awesome! |
For reference: I've got the board, so when it's time to test I'm happy to do so. |
I get only
when trying to flash. Could you maybe also update the udev-rules in |
Needs rebase, and please address my comment. |
Ping? |
169dd0b
to
92601db
Compare
@miri64 I have rebased this branch on master latest, in order to correct the conflicts, run static-tests and test on target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good for you so that this is merged in the next release ?
After having a look at it, I think it it could make it. I have a few comments, see below.
Now
Are you sure the timer is configured correctly? |
Also, only squash if the reviewer asks you to. Otherwise it is hard to track your changes + I don't get notified when you force push ;-). |
c8d8800
to
60e158a
Compare
@miri64 I only saw your comment about the squash, after having pushed my last fix. I'm taking note for next time. |
I'm not sure, when I next come to test this, but it might be that you need to adapt for #9130 if it is merged before :-/ |
@miri64 yes it will need some adaptation. However I think is limited to the removal of code duplication, should be straightforward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @aabadie? |
In the meantime @tprrt: some apps require the |
@tprrt the CI didn't pass (have a look at this output). On first sight it looks like some applications overflow this platforms memory. |
I rebased (required since upstream some additional tests were merged) and did that, but sadly I seem to be unable to push to |
60e158a
to
7226daf
Compare
😱 I did not intend to close this PR.... I somehow managed to push, but now I can't open it anymore oO |
Since the PR is now closed, I can't re-open the PR >.< (since I now can't push to your repo anymore)... |
So sorry >.< |
In the meantime: I stored what I actually wanted to push in https://github.com/miri64/RIOT/tree/leonardo-arduino/feat/initial. |
Since the PR is now closed, I can't re-open the PR >.<...
Maybe @tprrt can reopen it. I remember to recently reopen my own
closed PR.
|
In the meantime another round of refactoring of the AVR code took place, so that this PR would need to be rebased and adapted again. @tprrt: Thank you for the effort you put in this PR. I am under the impression that other helping hand to get this PR merged could be beneficial. If you agree I could create a new PR based on this one and take over from here. (But this would need to wait until I finish my vacation, as I don't have access to the board right now.) (Obviously, the new PR would still pay credit to you via the |
@maribu can you maybe do as proposed. You can find the original PR of this PR in the branch I mentioned in #7306 (comment):
|
@maribu No problem, you can do what you said. |
board/arduino-leonardo: add initial support (without usb cdc)