Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_init: rename auto_init_ng_netif to auto_init_gnrc_netif #3661

Merged
merged 2 commits into from
Aug 25, 2015

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Aug 19, 2015

As prophecised in its introduction: I missed that one in #3645.

But it wasn't that hard:

# remove legacy files
git rm -rf boards/samr21-xpro/auto_init_gnrc_netif/
git rm -rf tests/driver_*/auto_init_ng_netif/
# move directories
find . -type d -name auto_init_ng* | while read f; do
  git mv "${f}" "${f/_ng_/_gnrc_}"
done
# move files
find . -type f -name auto_init_ng* | while read f; do
  git mv "${f}" "${f/_ng_/_gnrc_}"
done
git grep --name-only "auto_init_ng" | 
  xargs sed -i 's/auto_init_ng/auto_init_gnrc/g'
git grep --name-only "AUTO_INIT_NG" |
  xargs sed -i 's/AUTO_INIT_NG/AUTO_INIT_GNRC/g'

@miri64 miri64 added Area: network Area: Networking Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. NSTF labels Aug 19, 2015
@miri64 miri64 added this to the Release 2015.08 milestone Aug 19, 2015
@OlegHahm
Copy link
Member

Can you put the cleanup of the test application in a separate commit?

@miri64 miri64 force-pushed the auto_init/api/auto_init_gnrc_netif branch from d6143a2 to b41e31b Compare August 19, 2015 15:22
@miri64
Copy link
Member Author

miri64 commented Aug 19, 2015

Done.

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 19, 2015
@jonas-rem
Copy link
Contributor

Seems good to me, but currently I don't have any hardware to test. I also haven't tracked the complete renaming process. So I suggest someone else should review and test this, sry.

@jfischer-phytec-iot Do you have a minute to verify and test it?

@miri64
Copy link
Member Author

miri64 commented Aug 20, 2015

Seems good to me, but currently I don't have any hardware to test. I also haven't tracked the complete renaming process. So I suggest someone else should review and test this, sry.

I mainly assigned you because I saw that you wrote one file I removed and took that as a great oportunity to assign someone else than my usual people :D. But if you are not able to test: please do re-assign :-)

@jonas-rem
Copy link
Contributor

I mainly assigned you because I saw that you wrote one file I removed and took that as a great oportunity to assign someone else than my usual people :D.

I appreciate that and I will hopefully be up on track in some weeks.

But if you are not able to test: please do re-assign :-)

I have no privileges for reassignment in Github. I will go to ask for them as soon as I will have more time to work on RIOT. Until then you need to carry out the reassignment ;).

@miri64 miri64 assigned kaspar030 and unassigned jonas-rem Aug 21, 2015
@miri64
Copy link
Member Author

miri64 commented Aug 21, 2015

Since @kaspar030 already made a duplicate PR of this I assign him :-)

@OlegHahm OlegHahm added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Aug 25, 2015
@kaspar030
Copy link
Contributor

ACK & go!

kaspar030 added a commit that referenced this pull request Aug 25, 2015
…rc_netif

sys: auto_init: rename auto_init_ng_netif to auto_init_gnrc_netif
@kaspar030 kaspar030 merged commit bd40b2c into RIOT-OS:master Aug 25, 2015
@miri64 miri64 deleted the auto_init/api/auto_init_gnrc_netif branch August 25, 2015 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants