tests: unblacklist some boards #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 11, 2015 18:40
| @@ -8,9 +8,6 @@ BOARD_BLACKLIST := arduino-mega2560 | |||
| # The MSP boards don't feature round(), exp(), and log(), which are used in the unittests | |||
| BOARD_BLACKLIST += chronos msb-430 msb-430h telosb wsn430-v1_3b wsn430-v1_4 z1 | |||
|
|
|||
| # Insufficient RAM / ROM | |||
| BOARD_INSUFFICIENT_RAM += redbee-econotag stm32f0discovery | |||
There was a problem hiding this comment.
I think the redbee-econotag needs to stay in:
/home/kietzmann/Dokumente/RIOT_repo_devel/RIOT/tests/libfixmath_unittests/bin/redbee-econotag/libfixmath_unittests.elf section `.heap' will not fit in region `ram'
/home/kietzmann/Downloads/gcc-arm-none-eabi-4_8-2014q2/bin/../lib/gcc/arm-none-eabi/4.8.4/../../../../arm-none-eabi/bin/ld: region `ram' overflowed by 1776 bytes
collect2: error: ld returned 1 exit status
|
Except the one comment above I'm fine with your PR (ran build tests locally). There is one other thing that appeared several times for the redbee-econotag, but it's unrelated. E.g. like this: |
|
And btw, my compiler version: |
|
Travis is fine with these changes - and Travis is actually the reason for blacklisting boards -> I would vote for merging this PR as is. ACK from my side @PeterKietzmann: are you ok with this? |
|
Ok let's do this |
PeterKietzmann
added a commit
that referenced
this pull request
Aug 25, 2015
tests: unblacklist some boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in reviewing #2926 it was discovered that the RAM/ROM blacklist of the stm32f0discovery board was no longer needed in
tests/vtimer_msg. This PR removes the blacklist from the tests which build correctly on my machine. Travis is using a different toolchain so it might give a different result though.