Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gcc-11 #348

Merged
merged 5 commits into from
Aug 22, 2021
Merged

Support gcc-11 #348

merged 5 commits into from
Aug 22, 2021

Conversation

StrikerRUS
Copy link
Member

Also, remove a line in README about rgf32.exe. We are no longer providing it.

@StrikerRUS
Copy link
Member Author

@mlampros Hey! Could you please help with new CRAN NOTE on Linux that we didn't face earlier?

* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
  ‘rgf’

Please feel free to push into this branch.

@mlampros
Copy link
Collaborator

hi @StrikerRUS. Let me have a look today afternoon to this new NOTE

@mlampros
Copy link
Collaborator

The NOTE mentions 'rgf' and 'rgf' is the root directory during checking. Would it help if we clean the temporary directory before we perform the check in the r_tests.sh file?

During my search based on the NOTE I found the following causes:
it might be a bug because it appears in the ubuntu-latest version (and we didn't encounter this error previously)
https://stat.ethz.ch/pipermail/r-package-devel/2020q4/006149.html
or somewhere in the scripts we start a web-browser or PDF viewer (as far as I can tell we don't do that)
either in the examples section
https://stackoverflow.com/a/62456524/8302386
or in the tests
https://stat.ethz.ch/pipermail/r-package-devel/2020q3/005701.html
or if there are any leftover files in the temporary directory
https://stackoverflow.com/a/62456199/8302386

Copy link
Collaborator

@mlampros mlampros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mlampros mlampros merged commit 4cec97f into master Aug 22, 2021
@StrikerRUS StrikerRUS deleted the ci_update branch August 22, 2021 13:53
@StrikerRUS
Copy link
Member Author

I've just uploaded a new version with this PR included
https://github.com/RGF-team/rgf/releases/tag/3.11.0
https://pypi.org/project/rgf-python/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants