Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codequality check via Github Actions #154

Merged
merged 8 commits into from
Dec 19, 2020
Merged

Codequality check via Github Actions #154

merged 8 commits into from
Dec 19, 2020

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Dec 18, 2020 •
edited
Loading

  • Add workflow for codeqailty checks (runs automatic)
  • moved common steps into a central .yml file to setup arduino-cli

@sidey79 sidey79 changed the base branch from master to dev-r3.5_xFSK December 19, 2020 00:32
@sidey79 sidey79 force-pushed the codequality-action branch 5 times, most recently from 6f89c80 to 8e581d8 Compare December 19, 2020 01:27
@sidey79
Create codeql-analysis.yml
93db0ed
@sidey79
Delete build.sh
4a524f2 
remove unused file
@sidey79
Delete deploy.sh
d55e121 
remove unused file

Update codeql-analysis.yml
@sidey79
Update codeql-analysis.yml
4cc6f0b 
Create codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml

updated static link step to be compatible with all boards

Update codeql-analysis.yml

Update codeql-analysis.yml

Update codeql-analysis.yml
@sidey79
Update codeql-analysis.yml
12d10e4
@sidey79
Update codeql-analysis.yml
0a35bf8
@sidey79
Update codeql-analysis.yml
2e15bb1
@sidey79
.github\actions\arduino-cli\action.yml
4f644bc 
move common steps to prepatr arduino-cli into a composite step and refenrence on it in the workflows:
- workflows/codeql-analysis.yml
- workflows/unittest.yml
@sidey79 sidey79 changed the title Create codeql-analysis.yml Codequality check via Github Actions Dec 19, 2020
@sidey79 sidey79 merged commit e489006 into dev-r3.5_xFSK Dec 19, 2020
@sidey79 sidey79 deleted the codequality-action branch December 19, 2020 09:17
sidey79 added a commit that referenced this pull request Jul 7, 2022
@sidey79 @HomeAutoUser
@uwekaditz @devzero84 @elektron-bbs
FSK Support (#252)
b04cb21 
* Make a 3.4 Branch

* SIGNALDuino.ino | SIGNALESP.ino

Fixes default parameter definition

* Implement a Wifi reconnect event to restart the telnet server (#120)

* SIGNALESP.ino

Implement a Wifi reconnect event to restart the telnet server
Set ArduinoJson Version to the desired one

* commands.h

fixed output of version after ping response

* fix names

- fix cc1101 name

* FIX: value of success must be saved before calling reset()

success must be saved before calling reset() because reset() will set it back to FALSE

* [SIGNALESP] FIX: Min. timer time for cronTimer is 1ms

if duration is greater than maxPulse it could happen that the timer time for the cronjob timer becomes negative (or a big value if it is unsigned)

* NEW: Settings if LED_BUILTIN on WEMOS boards as PIN_LED

* baseline for plattformio

* Changes to be compatible with plattformio

* signalesp.h

prevent crash if first char is a linebreak or #

* commands.h

fix unsupported command output which caused a crash

* Arduino IDE compatibility

Added sym links to project files to support arduino compatible layout

* Linked ArduinoJson per file

* platformio.ini

corrected exclude for arduino-ide compatible directory

* corrected CMakeLists.txt for testproject

added testproject to plattformio.ini (does not work)

* build.sh

updated build config and travis config for arduino-ide dir structure

* change travis build config

* clear links

* modified symlinks to be relative

* remove some symlinks to add again

* added symlinks again

* rename dir

* removed file to link later

* added symlinks

* build.sh deploy.sh

executable flag added

* added missing timerone header

* added missing cpp file

* fix compile

* travis

changed arduino core version to 2.6.3

* travis

update arduino cmd

* fixed arduino cmd

* added missing symlinks

* cc1101.cppAdded wait_miso call after select to repair factory reset

* signalesp.h

fixed crash with ; as command

* signalesp.h

modified connection handling

commands.h

added dumpEEPROM when doing factory reset

* SimpleFIFO.h

enqueue: ICACHE_RAM_ATTR added to support usage via interrupt

* Version 3.4.0-dev+20200216

* platformio.ini

added nanocc1101 and nanocc1101@debug

* send.h
fix unexpected serial print until null termination char is found

* platformio.ini

Compile definition for serval boards added

* send.h
cleanup some code

* signalDecoder/src/signalDecoder.cpp

prevents crashes

* Update some compile errors

* Update platformio.ini

* added different bootloaders
* revised HW names
* revised minicul 8/16MHz
* added monitor_port / upload_port variable to define on start

* Update cc1101.cpp

* fix
- no compile in Arduino IDE from nano, promini, esp8266 without cc1101 but with DEBUG flag
- no compile in PlatformIO from nano, promini, esp8266 without cc1101 but with DEBUG flag

* Update signalduino.h

* revised PROGVERS

* Update signalduino.h

* wrong date from PR

* Update platformio.ini

* revised ESP32 config to upload and view monitor

* Update platformio.ini

* revised ESP32 device useful note
* duplicate ESP32 device for DEBUG

* commands.h

add 0x17 chipid for cc1101

* Update commands.h

Fixes syntax, corrected chipid
#133

* ESP32 support (#134)

 * revised for ESP32 (#130)
platformio.ini
  * revised
  * remove comments & sort devices
  * remove @lastest comment from esp8266
compile_config.h
  * added PIN´s for ESP32
  * revised comments
signalesp.h
  * revised code for ESP32 (timings, WiFi.events)
  * fix code line event
signalduino.h
  * revised date
README.md
  * added doc

* Update .travis.yml - ESP32 compile (#137)

* Update .travis.yml
* option to compile ESP32 11d8ece

* Update .travis.yml
* option to compile ESP32 without cc1101 11d8ece

* Maple Mini (stm32f103cbt6) support (#136)

* Hardware stm32f103cbt6 integrated
* code and config adapted to compile with and without cc1101

* Update dev r3.4 with PlattformIO Updates incl STM Support (#138)

* signalesp.h

prevent crash if first char is a linebreak or #
fixed crash with ; as command
modified connection handling


* commands.h

added dumpEEPROM when doing factory reset
fix unsupported command output which caused a crash
add 0x17 chipid for cc1101

* Arduino IDE compatibility

Added sym links to project files to support arduino compatible layout

* Linked ArduinoJson per file

* platformio.ini

corrected exclude for arduino-ide compatible directory

* corrected CMakeLists.txt for testproject

added testproject to plattformio.ini (does not work)


* build.sh

updated build config and travis config for arduino-ide dir structure

* travis

changed arduino core version to 2.6.3

* cc1101.cpp
Added wait_miso call after select to repair factory reset


* SimpleFIFO.h

enqueue: ICACHE_RAM_ATTR added to support usage via interrupt


* send.h
fix unexpected serial print until null termination char is found
cleanup some code

* signalDecoder/src/signalDecoder.cpp
prevents crashes

* Update some compile errors

* ESP32 support (#134)

* Maple Mini (stm32f103cbt6) support (#136)

* Update platformio.ini (#141)

* added radinoCC1101 to compile
* revised comments
* testet again all PIN´s and compatibility
  (ICT radino is based on Arduino Leonardo & Micro)

* fix - strobe commands register (#140)

* Update cc1101.cpp

* fix strobe commands register

* Update / fix deploy travis config (#142)

* travis.yml

updated yml for successful deployment of release
fixed some yaml warnings on travis

* extension of xFSK mode (#145)

* xFSK extension

extra_script.py
  * creation file for easy file generation (firmware)
platformio.ini
  * extension of hardware and special debug versions

any files: bitstore.h, cc1101.cpp, cc1101.h, commands.h,
compile_config.h, functions.h, output.cpp, output.h,
send.h, signalDecoder.cpp, signalDecoder.h, signalSTM.h,
signalduino.h, signalesp.h
  * extension of xFSK mode (send & receive)
  * change notation of calls due to excessive memory consumption
    (smaller alternative is used)
  * memory comparison completed -> optimizations for the program sequence
    - processing on weak hardware runs faster, example: radino, nano
    - more memory space of the processors
  * revised debug texts

* create symblink

* Update signalDecoder.cpp

  * revised comment for a clear statement

* Update signalDecoder.h

  * added comments
  * added SIGNALduino project query added for linkage

* Update output.cpp

  * added SIGNALduino project query added for linkage

* rename variable and revised comments

* revised comments to better understanding

* optimized code / string class / xFSK send call

cc1101.cpp
  * revised string class in void sendFIFO
  * optimized void sendFIFO
cc1101.h
  * revised call void
send.h
  *  optimized call xFSK to send

* Update output.cpp

* revised size comments

* Update signalDecoder.h

* added comments
* macro SDC_PRINT, SDC_WRITE, SDC_PRINTLN inserted to test

* Update compile_config.h

* Update compile_config.h

* revised code

signalDecoder.cpp
  * MSG_PRINT | DBG_PRINT write back to SDC_PRINT
  * optimized some lines
output.cpp
  * revised comments

* back to big memory size functions

signalDecoder.cpp
  * back to big memory size sprintf to save ready compile
platformio.ini
  * revised some comments to view result

* Update signalDecoder.cpp

* back to big memory size sprintf to save ready compile

* Update signalDecoder.cpp

* back to big memory size sprintf to save ready compile

* Update platformio.ini

* revised comments size & version

* Update signalDecoder.cpp

* fix not compile with define DEBUGDECODE
  (wrong parameter, macro "SDC_WRITE" passed 2 arguments, but takes just 1)

* Update signalDecoder.cpp

* fix not compile with define DEBUGDECODE
(in POI | error:   initializing argument 1 of .... )

* Update platformio.ini

* sort hardware for better overview
* revised sketch size comments

* Update compile_config.h

* Update output.cpp

* for test

* delete output.cpp

* delete output.cpp
(UNITTEST have no link to compile_config.h)
* added functions in some files

* update code after REVIEW

send.h
  * #145 (comment)
 * remove omment
compile_config.h
  * #145 (comment)
  * revised PROGVERS variable
cc1101.cpp
  * corrected indentation
signalDecoder.h
  * #145 (comment)
  * comment changed

* create output.cpp for functions in project

cc1101.cpp
  * transfer function MSG_PRINTtoHEX
functions.h
  * transfer function DBG_PRINTtoHEX

* create symblink

* fix output ESP32 & ESP 8266 (#148)

* fix output ESP32 & ESP 8266
- fix, no calling of commands possible

* dev-r3.5_xFSK_tab_comments - revision indentation (#149)

* Update signalDecoder.cpp
  * revised indentations
  * revised comments

* Update signalDecoder.h
  * revised comments

* Update compile_config.h
  * revised version

* sketch optimized for hardware with little flash (#150)

* sketch optimized for hardware with little flash

* platformio.ini
  - revised sketch size comments
* signalesp.h
  -  increase writeBufferSize
* compile_config.h
  - revised PROGVERS
  - revised comments
* signalDecoder.h
  - added new function
* signalDecoder.cpp
  - added new functions myitoa (selfmade alternative to non standard itoa function c++)
  - remove some sprintf and revised to alternate better sketch size function SDC_PRINT
  - remove old comments
  - added function SDC_PRINT_intToHex / nibble_to_HEX
  - limit array

* fix writeBufferSize for ESP

* fix writeBufferSize for ESP (#151)

* CI Jobs auf Gihub actions übertragen (#152)

* .github\workflows\unittest.yml

Added unittest workflow
Made scrips executable and renamed travis ci yaml file
Use more recent (latest supported rapidassist) version
added all boards and combinations to workflow
excluded some combinations
Added github actions unittest workflow, which tests and uploads to a created relese

* Compile micro8 mhz (#155)

* .github\workflows\unittest.yml

- added radino board with incicuit board files
- Added dependency between unittest and deploy jobs to run in sequence
- renamed firmware to be compatible with flash command from module

* Update README.md
Updated badge in readme

* Codequality check via Github Actions (#154)

* Create codeql-analysis.yml

* Delete build.sh

* Delete deploy.s

* created .github\actions\arduino-cli\action.yml

move common steps to prepatr arduino-cli into a composite step and refenrence on it in the workflows:
- workflows/codeql-analysis.yml
- workflows/unittest.yml

* Upload compiled firmwares always as artifacs (#159)

 Artifacts are always placed at github actions to get the compiled firmware files

* fix-esp8266-firmware-debug (#158)

* ./github/unittest.yml

- Removed debug options for compiler (esp8266) #157
- Upload compiled firmwares always as artifacs (#159)
- generate a comment output with the flash and ram usage
- changed submodule checkout to checkout action

* unittest.yml

run comments only if this is a pullrequest

* Update action.yml

spell fix

* Update compile_config.h (#156)

* Update signalduino.h

Add all pins as input pullup

* Fix wait_Miso defines in cc1101.h (#213)

Static variables are only initialized once so the implementation only
worked for a total of 255 iterations.
After that, functions like cmdStrobe(), readReg() or
writeReg() return immediately if the MISO pin is high.

The variable miso_count is now out of while's scope and therefore no
longer needs to be static.

* Fix - GFSK & nano crash (#211)

* dev-r3.5_xFSK Bugfix GFSK
 - Allows other modulations than ASK / OOK and 2-FSK to be received.

* fix nano328 send crash
 - revised PROGVERS
 - pins excluded to avoid crash
 - revised comment & changed pins
 - revised code PullUp loop #211 (comment)

* Fixes a endless loop in mcdecoder  (#228)

* CMakeList.txt
- Added policy for new cmake versions

* win32arduino
- updated to newest version

* test.cpp
- Added test to find endlesslopp

* signalDecoder.cpp
- try to avoid var overflow
- modify if conditions checking

* signalDecoder.cpp
- Fix not stopping early enough

* signalDecoder.cpp
- fix to last exit for shorts

* signalDecoder.cpp
- revert mpi and mpiplusone checking

* install_rapidassists.sh
- Update to version 0.10.0 to be compatible with win32arduino

* Update codeql-analysis.yml , platformio.ini (#244)

* Update codeql-analysis.yml

* Update platformio.ini
 - remove old event
 - update information
 - comment out hardware bootloader_v2 due to errors in the core

* Update unittest.yml

* Update signalDecoder.cpp (#245)

* Update signalDecoder.cpp
  - fix, code cannot compile with debug option DEBUGDECODE

* Update codeql-analysis.yml
  - use actions checkout also for submodules

* LED confirms receipt of FSK (#251)

Pin reception works at FSK inverted to OOK.

* Update platformio.ini

- useful hints added

Co-authored-by: HomeAutoUser <[email protected]>
Co-authored-by: uwekaditz <[email protected]>
Co-authored-by: devzero84 <[email protected]>
Co-authored-by: Udo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HomeAutoUser HomeAutoUser HomeAutoUser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidey79 @HomeAutoUser