fix: sanitize file name #1728
Merged
fix: sanitize file name #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
StanGirard
approved these changes
Nov 27, 2023
StanGirard
added a commit
that referenced
this pull request
Nov 28, 2023
🤖 I have created a release *beep* *boop* --- ## 0.0.121 (2023-11-28) ## What's Changed * fix: update max token logic by @mamadoudicko in #1725 * fix: update public brain subscription logic by @mamadoudicko in #1727 * fix: sanitize file name by @mamadoudicko in #1728 * feat(publicBrains): use join queries for better performance by @mamadoudicko in #1730 * feat: improve delete knowledge performance by @mamadoudicko in #1733 * fix: 🐛 crawler by @StanGirard in #1735 * feat: 🎸 local user by @StanGirard in #1736 **Full Changelog**: v0.0.120...v0.0.121 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst
added a commit
to coolCatalyst/quivr
that referenced
this pull request
Jun 1, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.121 (2023-11-28) ## What's Changed * fix: update max token logic by @mamadoudicko in QuivrHQ/quivr#1725 * fix: update public brain subscription logic by @mamadoudicko in QuivrHQ/quivr#1727 * fix: sanitize file name by @mamadoudicko in QuivrHQ/quivr#1728 * feat(publicBrains): use join queries for better performance by @mamadoudicko in QuivrHQ/quivr#1730 * feat: improve delete knowledge performance by @mamadoudicko in QuivrHQ/quivr#1733 * fix: 🐛 crawler by @StanGirard in QuivrHQ/quivr#1735 * feat: 🎸 local user by @StanGirard in QuivrHQ/quivr#1736 **Full Changelog**: QuivrHQ/quivr@v0.0.120...v0.0.121 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
Turns out sanitizer is really strict. It doesn't pass any national chars at all. Looking for more i18n tolerant sanitizer. |
Dream528
added a commit
to Dream528/quivr
that referenced
this pull request
Jul 28, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.121 (2023-11-28) ## What's Changed * fix: update max token logic by @mamadoudicko in QuivrHQ/quivr#1725 * fix: update public brain subscription logic by @mamadoudicko in QuivrHQ/quivr#1727 * fix: sanitize file name by @mamadoudicko in QuivrHQ/quivr#1728 * feat(publicBrains): use join queries for better performance by @mamadoudicko in QuivrHQ/quivr#1730 * feat: improve delete knowledge performance by @mamadoudicko in QuivrHQ/quivr#1733 * fix: 🐛 crawler by @StanGirard in QuivrHQ/quivr#1735 * feat: 🎸 local user by @StanGirard in QuivrHQ/quivr#1736 **Full Changelog**: QuivrHQ/quivr@v0.0.120...v0.0.121 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo:
Screen.Recording.2023-11-27.at.12.13.45.mov
issue: #1719