feat: api definition in brain creation modal

[gozineb]

Description

#1569

Checklist before requesting a review

Please delete options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented hard-to-understand areas
• I have ideally added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

Screenshots (if appropriate):

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2023 9:55am
quivr-strapi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2023 9:55am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2023 9:55am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/config/defaultBrainConfig.ts

The change in this file is also low risk. The developer has added a new property knowledgeSource to the defaultBrainConfig object. However, it's important to ensure that all parts of the code that use this object are updated to handle this new property. If not, it could potentially cause issues. For example:

if (defaultBrainConfig.knowledgeSource) {
  // do something with knowledgeSource
}

This would ensure that the code only tries to use knowledgeSource if it is defined.

---

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/AddBrainModal/AddBrainConfig.tsx

1. The onClick event handler for the Button component is set to () => void 0. This is a no-op and might be a placeholder. If it's not intended to do anything, it's better to remove the onClick prop entirely.
2. The form is commented out. If it's not needed, it's better to remove it to avoid confusion.
3. The openAiKey field seems to be a sensitive field. Make sure it's handled securely and not exposed.
4. The setSelectedTab function is called directly in the component body. This will be called on every render which is not ideal. It should be called inside a useEffect or event handler.

Suggested changes:

1. Remove the onClick prop from the Button component if it's not needed.
2. Remove the commented out form if it's not needed.
3. Ensure the openAiKey field is handled securely.
4. Move the setSelectedTab function call inside a useEffect or event handler.

---

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/AddBrainModal/hooks/useAddBrainModal.ts

1. The handleSubmit function is quite large and complex. It might be a good idea to break it down into smaller, more manageable functions.
2. The catch block in the handleSubmit function stringifies the error object directly. This might not give useful information in the log. It's better to log the message property of the error.

Suggested changes:

1. Break down the handleSubmit function into smaller functions.
2. Log the message property of the error in the catch block.

---

🔍🔐🔄

---

Powered by Code Review GPT