Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supabase vault #1605

Merged
merged 3 commits into from
Nov 7, 2023
Merged

feat: supabase vault #1605

merged 3 commits into from
Nov 7, 2023

Conversation

gozineb
Copy link
Contributor

@gozineb gozineb commented Nov 7, 2023

Description

#1551

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Nov 7, 2023
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 3:51pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 3:51pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 3:51pm

@gozineb gozineb changed the title Feat/supabase vault feat: supabase vault Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/backend/repository/external_api_secret/read_secret.py

  1. The function read_secret does not have a type hint for secret_value. This could lead to potential bugs in the future. Please add a type hint for secret_value.

Example:

 def read_secret(
    user_id: UUID, brain_id: UUID, secret_name: str, secret_value: str
) -> UUID | None:
  1. The function read_secret does not handle any potential exceptions that might be thrown by supabase_client.rpc. Consider adding a try-except block to handle potential exceptions.

Risk Level 2 - /home/runner/work/quivr/quivr/backend/repository/external_api_secret/delete_secret.py

The function delete_secret does not handle any potential exceptions that might be thrown by supabase_client.rpc. Consider adding a try-except block to handle potential exceptions.


Risk Level 2 - /home/runner/work/quivr/quivr/backend/repository/external_api_secret/create_secret.py

  1. The function create_secret does not have a type hint for secret_value. This could lead to potential bugs in the future. Please add a type hint for secret_value.

Example:

 def create_secret(
    user_id: UUID, brain_id: UUID, secret_name: str, secret_value: str
) -> UUID | None:
  1. The function create_secret does not handle any potential exceptions that might be thrown by supabase_client.rpc. Consider adding a try-except block to handle potential exceptions.

🔍🐛🛠️


Powered by Code Review GPT

@gozineb gozineb merged commit ed5de8b into main Nov 7, 2023
7 of 8 checks passed
mamadoudicko pushed a commit that referenced this pull request Nov 8, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.108 (2023-11-07)

## What's Changed
* feat: add api_brain_definition table by @mamadoudicko in
#1601
* feat: add brain_type column to brain table by @mamadoudicko in
#1603
* feat: supabase vault by @gozineb in
#1605


**Full Changelog**:
v0.0.107...v0.0.108

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.108 (2023-11-07)

## What's Changed
* feat: add api_brain_definition table by @mamadoudicko in
QuivrHQ/quivr#1601
* feat: add brain_type column to brain table by @mamadoudicko in
QuivrHQ/quivr#1603
* feat: supabase vault by @gozineb in
QuivrHQ/quivr#1605


**Full Changelog**:
QuivrHQ/quivr@v0.0.107...v0.0.108

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Dream528 added a commit to Dream528/quivr that referenced this pull request Jul 28, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.108 (2023-11-07)

## What's Changed
* feat: add api_brain_definition table by @mamadoudicko in
QuivrHQ/quivr#1601
* feat: add brain_type column to brain table by @mamadoudicko in
QuivrHQ/quivr#1603
* feat: supabase vault by @gozineb in
QuivrHQ/quivr#1605


**Full Changelog**:
QuivrHQ/quivr@v0.0.107...v0.0.108

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants