feat(brainSettings): rework knowledge tab

[mamadoudicko]

Issue: #1435

• feat(knowledgeTab): update structure
• refactor: change AddKnowledge structure
• feat: change AddKnowledge component structure
• feat: rework sources logic
• feat: change knowledge tab upload process
• fix: change knowledge tab fetch, create, update logic
• feat: improve added knowledge ui
• style: improve responsivity

Fix:

• [Bug]: After uploading the file, I cannot see the uploaded file in my brain. It still shows as empty. #1516
• [Bug]: File removed from the brain not listed but still exists #1336
• [BUG]Upload or delet files in the brain is not working properly. It shows success, but in reality, it does not take effect. #1204

Screen.Recording.2023-10-31.at.18.49.44.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2023 5:41pm
quivr-strapi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2023 5:41pm
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2023 5:41pm

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/hooks/useBrainManagementTabs.ts

The code changes seem to be safe, but there are some improvements that can be made for readability and error handling:

1. The handleUnsubscribeOrDeleteBrain function has a lot of responsibilities. Consider breaking it into smaller functions.

2. The error handling in the handleUnsubscribeOrDeleteBrain function could be improved. Currently, it just logs the error to the console. Consider adding user-friendly error messages or handling specific error types differently.

---

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/KnowledgeTab/components/KnowledgeTable/components/KnowledgeItem/hooks/useKnowledgeItem.ts

The onDeleteKnowledge function has a high risk score due to the lack of error handling. If the deleteKnowledge function throws an error, the invalidateKnowledgeDataKey function will not be called, potentially leading to stale data.

try {
  if (brainId === undefined) {
    throw new Error(t(\"noBrain\", { ns: \"explore\" }));
  }
  await deleteKnowledge({
    brainId,
    knowledgeId: knowledge.id,
  });
  invalidateKnowledgeDataKey();
  publish({
    variant: \"success\",
    text: t(\"deleted\", {
      fileName: knowledge_name,
      brain: brain?.name,
      ns: \"explore\",
    }),
  });
} catch (error) {
  publish({
    variant: \"warning\",
    text: t(\"errorDeleting\", { fileName: knowledge_name, ns: \"explore\" }),
  });
  console.error(\"Error deleting\", error);
}

Consider wrapping the deleteKnowledge function in a try-catch block and handle the error properly.

---

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/KnowledgeTab/components/AddKnowledge/hooks/useFeedBrain.ts

The feedBrain function has a high risk score due to the lack of error handling. If the createChat or handleFeedBrain functions throw an error, the deleteChat function will not be called, potentially leading to memory leaks.

const currentChatId = (await createChat(\"New Chat\")).chat_id;
try {
  dispatchHasPendingRequests?.();
  closeFeedInput?.();
  setHasPendingRequests(true);
  await handleFeedBrain({
    brainId,
    chatId: currentChatId,
  });
  setKnowledgeToFeed([]);
} catch (e) {
  publish({
    variant: \"danger\",
    text: JSON.stringify(e),
  });
} finally {
  setHasPendingRequests(false);
  await deleteChat(currentChatId);
}

Consider wrapping the createChat function in a try-catch block and handle the error properly.

---

🔨🔧🚨

---

Powered by Code Review GPT

[StanGirard]

Very Nice !!!!