-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update onboarding steps #1337
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatDialogueArea/components/ChatDialogue/components/Onboarding/Onboarding.tsx The code seems to be well written and follows SOLID principles. However, there are a few areas that could be improved for better readability and maintainability:
Here's how you could implement these changes: const isOnboardingEnabled = useFeatureIsOn(\"onboarding\");
if (!isOnboardingEnabled) {
return null;
}
const { streamingText: secondStepStream, isDone: isStep2Done } = useStreamText({
text: step2,
enabled: isStep1DetailsDone,
}); 🔤🔍🔄 Powered by Code Review GPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noiiiiice
This reverts commit f13f08c.
🤖 I have created a release *beep* *boop* --- ## 0.0.89 (2023-10-09) ## What's Changed * feat: enable CSP in all environments (local/preview/prod) by @matthieujacq in #1334 * feat: enhance user page UI by @nguernse in #1319 * feat: update onboarding steps by @mamadoudicko in #1337 * feat: add onboarding_a column to onboarding table by @mamadoudicko in #1340 * fix(question): fixed with user_settings by @StanGirard in #1349 * FIX tables.sql - missing ; breaks SQL queries. by @stanrb in #1348 * feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in #1345 * test: add chat e2e tests by @mamadoudicko in #1344 * feat: configure CSP for self-hosting and multiple ports in dev mode by @matthieujacq in #1364 ## New Contributors * @stanrb made their first contribution in #1348 **Full Changelog**: v0.0.88...v0.0.89 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## 0.0.89 (2023-10-09) ## What's Changed * feat: enable CSP in all environments (local/preview/prod) by @matthieujacq in QuivrHQ/quivr#1334 * feat: enhance user page UI by @nguernse in QuivrHQ/quivr#1319 * feat: update onboarding steps by @mamadoudicko in QuivrHQ/quivr#1337 * feat: add onboarding_a column to onboarding table by @mamadoudicko in QuivrHQ/quivr#1340 * fix(question): fixed with user_settings by @StanGirard in QuivrHQ/quivr#1349 * FIX tables.sql - missing ; breaks SQL queries. by @stanrb in QuivrHQ/quivr#1348 * feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in QuivrHQ/quivr#1345 * test: add chat e2e tests by @mamadoudicko in QuivrHQ/quivr#1344 * feat: configure CSP for self-hosting and multiple ports in dev mode by @matthieujacq in QuivrHQ/quivr#1364 ## New Contributors * @stanrb made their first contribution in QuivrHQ/quivr#1348 **Full Changelog**: QuivrHQ/quivr@v0.0.88...v0.0.89 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## 0.0.89 (2023-10-09) ## What's Changed * feat: enable CSP in all environments (local/preview/prod) by @matthieujacq in QuivrHQ/quivr#1334 * feat: enhance user page UI by @nguernse in QuivrHQ/quivr#1319 * feat: update onboarding steps by @mamadoudicko in QuivrHQ/quivr#1337 * feat: add onboarding_a column to onboarding table by @mamadoudicko in QuivrHQ/quivr#1340 * fix(question): fixed with user_settings by @StanGirard in QuivrHQ/quivr#1349 * FIX tables.sql - missing ; breaks SQL queries. by @stanrb in QuivrHQ/quivr#1348 * feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in QuivrHQ/quivr#1345 * test: add chat e2e tests by @mamadoudicko in QuivrHQ/quivr#1344 * feat: configure CSP for self-hosting and multiple ports in dev mode by @matthieujacq in QuivrHQ/quivr#1364 ## New Contributors * @stanrb made their first contribution in QuivrHQ/quivr#1348 **Full Changelog**: QuivrHQ/quivr@v0.0.88...v0.0.89 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
#1331
Screen.Recording.2023-10-05.at.17.25.44.mov