Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding): add step 2 #1314

Merged
merged 2 commits into from
Oct 3, 2023
Merged

feat(onboarding): add step 2 #1314

merged 2 commits into from
Oct 3, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Oct 3, 2023

Screen.Recording.2023-10-03.at.16.52.53.mov

#1309

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 3, 2023
@mamadoudicko mamadoudicko temporarily deployed to preview October 3, 2023 14:49 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:28pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:28pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:28pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatDialogueArea/components/ChatDialogue/components/Onboarding/components/Step1.tsx

The code is generally clean and readable. However, there is a potential issue with the Link component. The download attribute is not supported in the Link component from next/link. You should use an a tag instead.

<a
  href=\"/documents/doc.pdf\"
  download
  target=\"_blank\"
  referrerPolicy=\"no-referrer\"
  onClick={() => changeStateTo(\"UPLOAD\")}
>
  <Button className=\"bg-black p-2 ml-2 rounded-full inline-flex\">
    <RiDownloadLine />
  </Button>
</a>

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatDialogueArea/components/ChatDialogue/components/Onboarding/hooks/useStreamText.ts

The code is generally clean and readable. However, there is a potential performance issue with the setInterval function. If the text prop changes while the interval is running, it could lead to unexpected behavior. Consider clearing the interval when the text prop changes.

useEffect(() => {
  let messageInterval: NodeJS.Timeout;

  if (enabled) {
    messageInterval = setInterval(() => {
      // ...
    }, 30);
  }

  return () => {
    clearInterval(messageInterval);
  };
}, [text, enabled]);

🔗🕰️🧹


Powered by Code Review GPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants