Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add public brain page #1230

Merged
merged 6 commits into from
Sep 21, 2023
Merged

feat: add public brain page #1230

merged 6 commits into from
Sep 21, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Sep 20, 2023

  • Add /GET brains/public route
  • Add new DTO PublicBrain
  • Add brain library page layout
  • Update SDK

#1208

Screen.Recording.2023-09-20.at.16.28.21.mov

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 4:25pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 4:25pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/AddBrainModal/AddBrainModal.tsx

The code changes in this file are mostly additions of new features and do not seem to introduce any breaking changes. However, there are a few areas that could be improved for better code quality and maintainability:

  1. Use of magic strings: The code contains several instances of hardcoded strings (e.g., \"translation\", \"brain\", \"config\"). These could be replaced with constants to avoid potential typos and make it easier to manage these values.

  2. Use of void 0: The void 0 expression is used in a few places. While this is not necessarily a problem, it can be confusing for some developers. Consider replacing it with a more explicit statement, such as return undefined;.

  3. Lack of input validation: The form inputs do not seem to have any validation. It would be good to add some basic validation to ensure that the inputs are in the expected format and range.


Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/api/brain/brain.ts

The changes in this file include the addition of a new function getPublicBrains and some changes to the parameters of existing functions. The risk is slightly higher due to the changes in function parameters, which could potentially break existing calls to these functions if not updated accordingly. However, the changes seem to be correctly implemented.


Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/api/brain/useBrainApi.ts

The changes in this file include the addition of a new function getPublicBrains to the returned object. This is a slightly higher risk as it modifies the object returned by useBrainApi, which could potentially break existing code if not handled correctly. However, the changes seem to be correctly implemented.


🧙‍♂️🔍📝


Powered by Code Review GPT

@gozineb gozineb merged commit 8172704 into main Sep 21, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants