feat(perf): increased perf embedding and search for files

[StanGirard]

Embedding is now a task

Created new task for embedding

Created new column file_sha 1

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	🛑 Canceled (Inspect)			Sep 15, 2023 9:40pm
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 15, 2023 9:40pm

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/backend/models/databases/supabase/vectors.py

The code changes are minimal and seem to be well written. However, there is a potential risk of the set_file_sha_from_metadata function not updating the file_sha1 field correctly. It would be better to add error handling to ensure that the update operation is successful.

+    def set_file_sha_from_metadata(self, file_sha1):
+        response = (
+            self.db.table(\"vectors\")
+            .update({\"file_sha1\": file_sha1})
+            .match({\"metadata->>file_sha1\": file_sha1})
+            .execute()
+        )
+        if response.error is not None:
+            raise Exception('Update operation failed')
+        return response

---

Risk Level 2 - /home/runner/work/quivr/quivr/backend/celery_task.py

The code seems to be well written and follows the SOLID principles. However, there is a potential risk of the get_supabase_db function not returning a valid database connection. This could lead to a NoneType error when trying to call database.set_file_sha_from_metadata(file_sha1). It would be better to add error handling to ensure that the database connection is valid before using it.

+    database = get_supabase_db()
+    if database is not None:
+        database.set_file_sha_from_metadata(file_sha1)
+    else:
+        raise Exception('Database connection failed')

---

📝🔍🐞

---

Powered by Code Review GPT