Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Homepage] 1.a AAUser, when I can sign-up with email-pwd / email-magic-link / google #1366

Closed
1 of 5 tasks
matthieujacq opened this issue Oct 9, 2023 · 2 comments
Closed
1 of 5 tasks
Assignees
Labels
area: frontend Related to frontend functionality or under the /frontend directory user story Subdivision of an epic

Comments

@matthieujacq
Copy link
Contributor

matthieujacq commented Oct 9, 2023

Link to the Epic

#1232

Explain the Functionality

Add options to sign up (in addition to email+password) :

  • magic link
  • google auth

Tech To-dos

  • Re-enable eslint on signin (component and hooks)
  • Add and style dummy buttons for the magic link and google auth in the signup page
  • Implement the magic link (bouton qui au clic invoque le callback fourni par useMagicLinkLogin)
  • Implement the google auth (bouton qui au clic invoque le callback fourni par useGoogleLogin)

Tests

  • []

Validation Checks

  • Try to sign-up and login with a magic link
@matthieujacq matthieujacq added the user story Subdivision of an epic label Oct 9, 2023
@matthieujacq matthieujacq self-assigned this Oct 9, 2023
@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 9, 2023
@dosubot
Copy link

dosubot bot commented Oct 9, 2023

🤖

Hello,

Thank you for your request. Based on the current version of Quivr (v0.0.88), the application already supports user authentication via email and password, as well as Google Login. This is evident from the presence of "email" and "password" fields in the JSON file and the "googleLogin" field which suggests that users can also authenticate using their Google accounts.

The current process for user sign-up in Quivr v0.0.88 is as follows:

  1. The user is presented with a sign-up form on the sign-up page. This form contains two fields: email and password. Both fields are required.
  2. The user enters their email and password into the respective fields.
  3. After filling in the details, the user submits the form by clicking the sign-up button.
  4. The handleSignUp function is called when the form is submitted. This function is responsible for the actual sign-up process.

As for your request to add and style dummy buttons for the magic link and google auth in the signup page, implement the magic link, and implement the google auth, I can confirm that these tasks are feasible. However, they would require significant changes to the current codebase, especially for the implementation of the magic link.

For the magic link implementation, we would need to set up an email service to send the magic link to the user's email. The magic link would contain a unique token that would be used to authenticate the user when clicked. This would require changes to both the frontend and the backend of the application.

For the Google auth implementation, we would need to set up a Google API project and configure it to allow authentication with Google. This would also require changes to both the frontend and the backend of the application.

I hope this answers your question. If you have any further questions or need clarification on anything, please feel free to ask.

Best regards,
Dosu

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@gozineb gozineb changed the title [New Homepage] A.1 AAUser, when I can sign-up with email-pwd / email-magic-link / google [New Homepage] 1.a AAUser, when I can sign-up with email-pwd / email-magic-link / google Oct 10, 2023
@matthieujacq
Copy link
Contributor Author

We will wait for the EPIC on the authentication page to avoid wasted time reworking it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory user story Subdivision of an epic
Projects
None yet
Development

No branches or pull requests

1 participant