Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated js-utils to handle Kinja images #119

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Use updated js-utils to handle Kinja images #119

merged 3 commits into from
Jul 20, 2022

Conversation

itsjustbrian
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jul 20, 2022

QZ-1061 Make image modification query params compatible with Kinja image CDN links

Links to images in the Wordpress library can be passed query parameters that transform the returned image depending on the need of the frontend

We modify these parameters in functions such as resize_wp_image

The Kinja image CDN has a different API for its image transform parameters. We need new functions to modify Kinja image links, adding equivalent transforms.

ramesh-kumar
ramesh-kumar previously approved these changes Jul 20, 2022
Copy link

@ramesh-kumar ramesh-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM

@itsjustbrian itsjustbrian merged commit 5b0a144 into main Jul 20, 2022
@itsjustbrian itsjustbrian deleted the qz-1061 branch July 20, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants