Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QZ-946 make @quartz/styles a dependency #118

Merged
merged 2 commits into from
Apr 26, 2022
Merged

QZ-946 make @quartz/styles a dependency #118

merged 2 commits into from
Apr 26, 2022

Conversation

sezgi
Copy link
Contributor

@sezgi sezgi commented Apr 25, 2022

As part of https://github.com/Quartz/qz-react/pull/6454, this PR moves the @quartz/styles package into the dependencies so that qz-react can run @quartz/interface without errors.

When we move @quartz/interface into the qz-react repo, we won't need to import @quartz/styles any more.

@linear
Copy link

linear bot commented Apr 25, 2022

QZ-946 Bring @quartz/styles repo into qz-react

Currently, it takes many unnecessary steps to maintain the https://github.com/Quartz/styles repo: update package version, create release tag, use the latest @quartz/styles commit hash in qz-react PR until the @quartz/styles PR is approved and the tag is published, etc. This PR brings the styles from the @quartz/styles repo into the qz-react repo to make these styles easier to maintain.

Also planning the same for the @quartz/interface repo.

Keeping the @quartz/styles repo itself around for now, so the iOS app can keep using it.

@sezgi sezgi merged commit bd8329e into main Apr 26, 2022
@sezgi sezgi deleted the styles-dep branch April 26, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants