Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump quick-xml to 0.28 #839

Merged
merged 8 commits into from
Mar 20, 2023
Merged

Bump quick-xml to 0.28 #839

merged 8 commits into from
Mar 20, 2023

Conversation

IvanIsCoding
Copy link
Collaborator

Closes #835

Bumps quick-xml to 0.28 before the old version 0.22 stops being compiled by future Rust versions (as said in the warnings)

@IvanIsCoding IvanIsCoding added this to the 0.13.0 milestone Mar 20, 2023
@coveralls
Copy link

coveralls commented Mar 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4464770973

  • 41 of 41 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 97.126%
Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 2 98.54%
Totals Coverage Status
Change from base Build 4463512345: 0.01%
Covered Lines: 13857
Relevant Lines: 14267
💛 - Coveralls

mtreinish
mtreinish approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this, I've started seeing the quick-xml warnings locally too so it'll be good to get on the latest version.

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Mar 20, 2023
@mergify mergify bot merged commit bdf55bd into Qiskit:main Mar 20, 2023
@IvanIsCoding IvanIsCoding deleted the update-quick-xml branch March 20, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

Update quick-xml before it breaks in future versions of Rust
3 participants
@IvanIsCoding @coveralls @mtreinish