Update pyo3 and numpy to 0.20.0 #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates PyO3 to the latest release 0.20.0 [1] and also moves rust-numpy to 0.20.0 [2] as well. The major change for rustworkx is official support for Python 3.12.0 final. We were previously using the 3.12 pre-release support in PyO3 to publish rustworkx for 3.12, but moving to the latest PyO3 officially supports the stable releases of 3.12. The are some small changes needed to adapt to API changes in PyO3, mostly around updates to the `PyDict.get_item()` api. [1] https://github.com/PyO3/pyo3/releases/tag/v0.20.0 [2] https://github.com/PyO3/rust-numpy/releases/tag/v0.20.0
IvanIsCoding
approved these changes
Oct 15, 2023
There was a problem hiding this comment.
LGTM, it's not surprising the functions that use Python's APIs the most are the ones that change from release to release. Most of our Rust code remains intact fortunately.
Also, on the topic of NumPy, I think we should consider numpy/numpy#24300. We probably should add restrictions to only depend on NumPy 1.0 until we confirm NumPy 2.0 works
| @@ -29,7 +29,7 @@ fixedbitset = "0.4.2" | |||
| hashbrown = { version = ">=0.13, <0.15", features = ["rayon"] } | |||
| indexmap = { version = ">=1.9, <3", features = ["rayon"] } | |||
| num-traits = "0.2" | |||
| numpy = "0.19.0" | |||
| numpy = "0.20.0" | |||
There was a problem hiding this comment.
Not this file but copy Qiskit/qiskit#10893 for us esssentially
There was a problem hiding this comment.
Yeah, that sounds good. We definitely should do this for the 0.14.0 release.
Pull Request Test Coverage Report for Build 6526320718
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates PyO3 to the latest release 0.20.0 [1] and also moves rust-numpy to 0.20.0 [2] as well. The major change for rustworkx is official support for Python 3.12.0 final. We were previously using the 3.12 pre-release support in PyO3 to publish rustworkx for 3.12, but moving to the latest PyO3 officially supports the stable releases of 3.12. The are some small changes needed to adapt to API changes in PyO3, mostly around updates to the
PyDict.get_item()api.[1] https://github.com/PyO3/pyo3/releases/tag/v0.20.0
[2] https://github.com/PyO3/rust-numpy/releases/tag/v0.20.0