Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QuantumCircuit.compose with Index exprs #12396

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix QuantumCircuit.compose with Index exprs #12396

merged 1 commit into from
May 14, 2024

Conversation

jakelishman
Copy link
Member

Summary

This was an oversight in d6c74c2 (gh-12310), where an ExprVisitor was missed in the testing.

Details and comments

No release note because it's fixing an unreleased bug. I did another check for ExprVisitor classes in Qiskit, and all of them appear to be updated.

@jakelishman
Fix QuantumCircuit.compose with Index exprs
1f816c4 
This was an oversight in d6c74c2 (Qiskitgh-12310), where an `ExprVisitor`
was missed in the testing.
@jakelishman jakelishman added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels May 13, 2024
@jakelishman jakelishman added this to the 1.1.0 milestone May 13, 2024
@jakelishman jakelishman requested a review from a team as a code owner May 13, 2024 17:09
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@jakelishman jakelishman mentioned this pull request May 13, 2024
Open
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9066983683

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 22 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 89.605%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 91.86%
crates/qasm2/src/parse.rs 18 95.77%
Totals Coverage Status
Change from base Build 9037095581: -0.03%
Covered Lines: 62187
Relevant Lines: 69401
💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue May 14, 2024
Merged via the queue into Qiskit:main with commit 58a383d May 14, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request May 14, 2024
@jakelishman @mergify
Fix QuantumCircuit.compose with Index exprs (#12396)
87261a6 
This was an oversight in d6c74c2 (gh-12310), where an `ExprVisitor`
was missed in the testing.

(cherry picked from commit 58a383d)
@mergify mergify bot mentioned this pull request May 14, 2024
Merged
@jakelishman jakelishman deleted the compose-var-index branch May 14, 2024 13:42
github-merge-queue bot pushed a commit that referenced this pull request May 14, 2024
@mergify @jakelishman
Fix QuantumCircuit.compose with Index exprs (#12396) (#12397)
6e0eea4 
This was an oversight in d6c74c2 (gh-12310), where an `ExprVisitor`
was missed in the testing.

(cherry picked from commit 58a383d)

Co-authored-by: Jake Lishman <[email protected]>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request May 31, 2024
@jakelishman @ElePT
Fix QuantumCircuit.compose with Index exprs (Qiskit#12396)
c3f593a 
This was an oversight in d6c74c2 (Qiskitgh-12310), where an `ExprVisitor`
was missed in the testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jakelishman @qiskit-bot @coveralls @mtreinish