Fix mpl circuit drawer with fold=-1 hanging with ControlFlow ops #12016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8299605997Details
💛 - Coveralls |
1ucian0
added
Changelog: Bugfix
1ucian0
approved these changes
Mar 18, 2024
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
) * Fix typing-extensions * Fix control flow with fold minus one (cherry picked from commit 43381ae) # Conflicts: # test/visual/mpl/circuit/test_circuit_matplotlib_drawer.py
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
) * Fix typing-extensions * Fix control flow with fold minus one (cherry picked from commit 43381ae)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
) (#12037) * Fix typing-extensions * Fix control flow with fold minus one (cherry picked from commit 43381ae) Co-authored-by: Edwin Navarro <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
…kport #12016) (#12036) * Fix mpl circuit drawer with fold=-1 hanging with ControlFlow ops (#12016) * Fix typing-extensions * Fix control flow with fold minus one (cherry picked from commit 43381ae) # Conflicts: # test/visual/mpl/circuit/test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * Update test_circuit_matplotlib_drawer.py * Update test/visual/mpl/circuit/test_circuit_matplotlib_drawer.py --------- Co-authored-by: Edwin Navarro <[email protected]> Co-authored-by: Luciano Bello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12012
Details and comments
This PR fixes a hang in the mpl circuit drawer when fold is set to -1 and there are ControlFlow ops in the circuit.