Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy qcstyle module #11545

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Jan 11, 2024

Summary

Deprecate the legacy module qiskit.visualization.qcstyle, which has been set for deprecation since Terra 0.22. The new location is qiskit.visualization.circuit.qcstyle.

@Cryoris Cryoris added the Changelog: Deprecation Include in "Deprecated" section of changelog label Jan 11, 2024
@Cryoris Cryoris added this to the 0.46.0 milestone Jan 11, 2024
@Cryoris Cryoris requested review from nonhermitian and a team as code owners January 11, 2024 16:10
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this object is totally meant to be public, perhaps we should import it into the qiskit.visualization.circuit namespace (at least in 1.0)?

In general the deprecation looks fine.

@Cryoris
Copy link
Contributor Author

Cryoris commented Jan 12, 2024

Yeah that's a good point, I'll add that (also here for consistency)

Actually: with the refactoring in #11536, the color scheme is no longer hardcoded into the DefaultStyle class, but only available in the JSON file. In that case, the class is less useful and it might be better to refer users to some docs page about the color scheme.

@jakelishman jakelishman added this pull request to the merge queue Jan 12, 2024
Merged via the queue into Qiskit:stable/0.46 with commit 000682d Jan 12, 2024
13 checks passed
@Cryoris Cryoris deleted the deprecate-legacy-qcstyle branch January 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants