Use function overloading to handle variations in strerror_r() impleme… #124

dx9 · 2018-01-28T13:59:20Z

?

zieckey · 2018-01-30T03:00:49Z

Do you test on all platforms? MACOSX, windows, linux ?

dx9 · 2018-01-30T17:24:54Z

I've tested it on alpine (XSI), ubuntu (GNU), and OS X (XSI). I don't have windows.

zieckey · 2018-01-31T08:17:54Z

evpp/sockets.cc

 #else
+std::string handle_strerror_r(char* s, char* buf) // GNU-specific


Change to const char* s is better.

…ntation. Avoids using macros or cmake to detect implementation. Inspired by https://zverovich.net/2015/03/13/reliable-detection-of-strerror-variants.html. Signed-off-by: John Coyle <[email protected]>

zieckey reviewed Jan 31, 2018

View reviewed changes

Use function overloading to handle variations in strerror_r() impleme…

b78b361

…ntation. Avoids using macros or cmake to detect implementation. Inspired by https://zverovich.net/2015/03/13/reliable-detection-of-strerror-variants.html. Signed-off-by: John Coyle <[email protected]>

dx9 force-pushed the wip-strerror_r branch from 71d795e to b78b361 Compare January 31, 2018 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use function overloading to handle variations in strerror_r() impleme… #124

Use function overloading to handle variations in strerror_r() impleme… #124

dx9 commented Jan 28, 2018

zieckey commented Jan 30, 2018

dx9 commented Jan 30, 2018

zieckey Jan 31, 2018

		#else
		std::string handle_strerror_r(char* s, char* buf) // GNU-specific

Use function overloading to handle variations in strerror_r() impleme… #124

Are you sure you want to change the base?

Use function overloading to handle variations in strerror_r() impleme… #124

Conversation

dx9 commented Jan 28, 2018

zieckey commented Jan 30, 2018

dx9 commented Jan 30, 2018

zieckey Jan 31, 2018

Choose a reason for hiding this comment