Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from source (e.g. via pre-commit) is broken by new poetry version #2077

Closed

Comments

@mhsmith
Copy link

mhsmith commented Jan 28, 2023

Poetry-core 1.5.0, which was released 30 minutes ago, adds additional validation for the extras section, which causes this error when installing from source:

% pip install --no-binary :all: -U isort
DEPRECATION: --no-binary currently disables reading from the cache of locally built wheels. In the future --no-binary will not influence the wheel cache. pip 23.1 will enforce this behaviour change. A possible replacement is to use the --no-cache-dir option. You can use the flag --use-feature=no-binary-enable-wheel-cache to test the upcoming behaviour. Discussion can be found at https://github.com/pypa/pip/issues/11453
Collecting isort
  Downloading isort-5.11.4.tar.gz (187 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 187.2/187.2 kB 3.7 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      Traceback (most recent call last):
        File "/Users/msmith/.venv/bw-310/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
          main()
        File "/Users/msmith/.venv/bw-310/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/Users/msmith/.venv/bw-310/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
        File "/private/var/folders/2t/th8vxc813_gcch7lkh1sbbmc0000gp/T/pip-build-env-cq_z9ahi/overlay/lib/python3.10/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
          poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
        File "/private/var/folders/2t/th8vxc813_gcch7lkh1sbbmc0000gp/T/pip-build-env-cq_z9ahi/overlay/lib/python3.10/site-packages/poetry/core/factory.py", line 57, in create_poetry
          raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

Unfortunately I think this affects everyone who uses isort via pre-commit.

@mhsmith
Copy link
Author

mhsmith commented Jan 28, 2023

To prevent something like this from happening again, maybe isort's pyproject.toml should pin a specific version of poetry-core.

@svntmr
Copy link

svntmr commented Jan 28, 2023

+1, I have the same problem

@ZwwWayne
Copy link

regoawt added a commit to Weird-Sheep-Labs/pycoho that referenced this issue Jan 28, 2023
Saran33 added a commit to Saran33/fastapi-docx that referenced this issue Jan 28, 2023
freefeynman123 added a commit to freefeynman123/historic-weather-forecast that referenced this issue Jan 28, 2023
chris48s added a commit to chris48s/cookiecutter-wagtail-package that referenced this issue Jan 28, 2023
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Jan 29, 2023
s0undt3ch added a commit to saltstack/salt that referenced this issue Jan 29, 2023
NICO-SOLUTIONS pushed a commit to NICO-SOLUTIONS/website that referenced this issue Jun 6, 2023
tbeadle pushed a commit to tbeadle/CAPEv2 that referenced this issue Jun 7, 2023
newer versions of poetry detect an issue with the pyproject.toml in
older versions of isort. See PyCQA/isort#2077.
kaynnan pushed a commit to Escodoo/website that referenced this issue Jun 27, 2023
Camille0907 pushed a commit to Camille0907/event that referenced this issue Jul 3, 2023
AungKoKoLin1997 pushed a commit to qrtl/partner-contact that referenced this issue Aug 10, 2023
Ricardoalso pushed a commit to camptocamp/crm that referenced this issue Sep 1, 2023
Ricardoalso pushed a commit to camptocamp/crm that referenced this issue Sep 1, 2023
Ricardoalso pushed a commit to camptocamp/crm that referenced this issue Sep 1, 2023
Ricardoalso pushed a commit to camptocamp/crm that referenced this issue Sep 1, 2023
Ricardoalso pushed a commit to camptocamp/crm that referenced this issue Sep 7, 2023
milesgranger added a commit to milesgranger/crick that referenced this issue Sep 12, 2023
yibudak pushed a commit to yibudak/queue that referenced this issue Nov 27, 2023
An update is needed because of isort library problems with pre-commit - PyCQA/isort#2077
bvanjeelharia pushed a commit to bvanjeelharia/website that referenced this issue Dec 18, 2023
kaynnan pushed a commit to Escodoo/website that referenced this issue Feb 1, 2024
Tardo pushed a commit to admingrupoisonores/web that referenced this issue Feb 19, 2024
Edward-Knight added a commit to Edward-Knight/landlock that referenced this issue Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment