setup.cfg: Replace dash-separated options #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of setuptools report that options with names separated by a dash (e.g. 'home-page') are deprecated and support will be removed in later versions.
ssbarnea
approved these changes
Sep 27, 2021
|
Hi,
I thought I tested it, but could have gotten mixed up since I submitted many similar PRs.
I'll double check today and let you know before merging.
Thanks
…On Mon, 27 Sep 2021, at 12:17, Sorin Sbarnea wrote:
***@***.**** commented on this pull request.
In setup.cfg <#64 (comment)>:
> @@ -30,12 +30,12 @@ console_scripts =
[flake8]
builtins = _
-show-source = True
I am almost sure flake8 does not recognize these, are you sure is ok?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#64 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALUSZAGVWIG2EZBVKZFMHBDUEBHFLANCNFSM5EVOGZTQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
No need to worry I read the docs of flake8 and you did right. I already released it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of setuptools report that options with names separated
by a dash (e.g. 'home-page') are deprecated and support will be
removed in later versions.