Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Syntax Theme Colors #112

Closed
wants to merge 1 commit into from
Closed

Use Syntax Theme Colors #112

wants to merge 1 commit into from

Conversation

chrisblatchley
Copy link

I think it would be cool to use the syntax theme colors for highlighting words. I've tried it with a few themes and I think it looks a lot better when it matches the cursor color.

I don't have an opinion on what colors the background colors should be, as I never use them. However, this PR might be a good place to decide.

@chrisblatchley chrisblatchley changed the title Use cursor color from syntax theme Use Syntax Theme Colors Jan 30, 2016
@richrace
Copy link
Member

I like this. But I think it should be an option to use the theme colour.

What do you think?

@chrisblatchley
Copy link
Author

Yeah, that sounds great to me. If you have an opinion on themed colors for background highlighting as well that would be cool to add in. I'm not sure how to add options, i've only trivially added this feature for myself. Maybe when you get a free moment, you can add that option?

@hgoodman
Copy link

+1 for using theme colors. Modifying luminance or transparency of the border theme color for text that is actually selected (or not selected) would also be a great improvement. FWIW, I think that non-rounded corners look better too.

@TheFinalDawn
Copy link

Great Idea!

@richrace richrace closed this Oct 28, 2020
@richrace richrace deleted the branch Pulsar-Edit-Highlights:master October 28, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants