Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Tags being removed #1

Closed
3 tasks done
molaeiali opened this issue Nov 3, 2023 · 19 comments
Closed
3 tasks done

Release Tags being removed #1

molaeiali opened this issue Nov 3, 2023 · 19 comments

Comments

@molaeiali
Copy link

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

  • I have searched open and closed issues for duplicates
  • This isn't a feature request
  • This is not a report about my app not working as expected

I am maintaining an AUR package for this program, and am compiling it based on the release version/tag you were providing, there was before a 0.20.1 tag and it's removed now, why are tags being removed and how can I reliably compile a specific version without them?

@molaeiali molaeiali changed the title Relase Tags being removed Release Tags being removed Nov 3, 2023
proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Nov 6, 2023
```
ERROR   src.manifest: Failed to check git python-proton-vpn-api-core/python-proton-vpn-api-core with AnityaChecker: Ref not found in https://github.com/ProtonVPN/python-proton-vpn-api-core: 'refs/tags/0.20.1'
```

ProtonVPN/python-proton-vpn-api-core#1
proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Nov 6, 2023
```
ERROR   src.manifest: Failed to check git python-proton-vpn-api-core/python-proton-vpn-api-core with AnityaChecker: Ref not found in https://github.com/ProtonVPN/python-proton-vpn-api-core: 'refs/tags/0.20.1'
```

ProtonVPN/python-proton-vpn-api-core#1
proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Nov 6, 2023
```
ERROR   src.manifest: Failed to check git python-proton-vpn-api-core/python-proton-vpn-api-core with AnityaChecker: Ref not found in https://github.com/ProtonVPN/python-proton-vpn-api-core: 'refs/tags/0.20.1'
```

ProtonVPN/python-proton-vpn-api-core#1
proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Nov 6, 2023
```
ERROR   src.manifest: Failed to check git python-proton-vpn-api-core/python-proton-vpn-api-core with AnityaChecker: Ref not found in https://github.com/ProtonVPN/python-proton-vpn-api-core: 'refs/tags/0.20.1'
```

ProtonVPN/python-proton-vpn-api-core#1
proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Nov 6, 2023
* fix: Ref not found on build

```
ERROR   src.manifest: Failed to check git python-proton-vpn-api-core/python-proton-vpn-api-core with AnityaChecker: Ref not found in https://github.com/ProtonVPN/python-proton-vpn-api-core: 'refs/tags/0.20.1'
```

ProtonVPN/python-proton-vpn-api-core#1

* fix: Ref not found on build

```
ERROR   src.manifest: Failed to check git python-proton-vpn-api-core/python-proton-vpn-api-core with AnityaChecker: Ref not found in https://github.com/ProtonVPN/python-proton-vpn-api-core: 'refs/tags/0.20.1'
```

ProtonVPN/python-proton-vpn-api-core#1

* fix: Ref not found on build

```
ERROR   src.manifest: Failed to check git python-proton-vpn-api-core/python-proton-vpn-api-core with AnityaChecker: Ref not found in https://github.com/ProtonVPN/python-proton-vpn-api-core: 'refs/tags/0.20.1'
```

ProtonVPN/python-proton-vpn-api-core#1
@calexandru2018
Copy link
Contributor

Hey @molaeiali sorry for the trouble, I'll look into it as I've created the releases but for some reason I noticed some of them I removed and rather left as drafts.

proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Nov 6, 2023
* fix: miss tray icon after #117

* fix: file not found on build

* fix: Ref not found on build

```
ERROR   src.manifest: Failed to check git python-proton-vpn-api-core/python-proton-vpn-api-core with AnityaChecker: Ref not found in https://github.com/ProtonVPN/python-proton-vpn-api-core: 'refs/tags/0.20.1'
```

ProtonVPN/python-proton-vpn-api-core#1
@molaeiali
Copy link
Author

The tag is removed again @calexandru2018

@molaeiali molaeiali reopened this Nov 6, 2023
@calexandru2018
Copy link
Contributor

Alright, we've setup gitlab mirroring but it seems like it's erasing releases created on github. We'll work on it but it will take some time, sorry for the problems it's causing.

@calexandru2018
Copy link
Contributor

calexandru2018 commented Nov 6, 2023

I've added it again, shall see how it goes (have made a change on our side).

@proletarius101
Copy link

@calexandru2018 Thanks for adding them back. But the tag for https://github.com/ProtonVPN/python-proton-vpn-session disappears again.

@calexandru2018
Copy link
Contributor

Hey sorry for this guys but there seems to be an issue with this and I'm not sure what the issue is, thus I'll be removing all releases as I don't know if it's the gitlab mirror setup that is removing them or something else (and this current setup seems to be unreliable).

@antermin
Copy link

antermin commented Nov 9, 2023

Can you please consider alternative / backup ways of source code distribution?

Many major software have the source code archives (and PGP signatures) for each release on their website, such as KDE.

repo.protonvpn.com is used for hosting Debian and Fedora binary packages, so I think that can also be used to host source archives (release tarballs).

@proletarius101
Copy link

proletarius101 commented Nov 10, 2023

I think the problem is that Proton doesn't set up the mirror properly. My project https://github.com/proletarius101/Insular/tags can successfully mirror tags from gitlab.com to github.com. The simplest solution might still be for them to fix the push mirror setting instead of setting up another source code site.

proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Nov 10, 2023
Disable the tag field and update checker before Proton fixes the issue: ProtonVPN/python-proton-vpn-api-core#1
proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Nov 10, 2023
* remove unnecessary permissions

* fix: tags not found

Disable the tag field and update checker before Proton fixes the issue: ProtonVPN/python-proton-vpn-api-core#1
@SebTM
Copy link

SebTM commented Nov 21, 2023

@antermin
Copy link

antermin commented Dec 8, 2023

Can developers please look into this issue again?

New releases and binary packages have been published on Nov 29 and Dec 5 (based on the ProtonVPN repo page), but currently the release tags are either missing or outdated, so it's difficult for packagers to track new ProtonVPN releases.

Taking this repo as an example, the latest version in Releases is still 0.20.1, while the actual latest version is 0.20.2.

@nyabinary
Copy link

bump

@calexandru2018
Copy link
Contributor

Hey all, we've managed to setup this properly, now every time we push a new version to stable, the github code is synced and the tags are also pushed.

@antermin
Copy link

@calexandru2018

Can you please add back the tags and releases for repos (at least for the most recent tag/version)?
For example, python-proton-core still has no tags and no releases.

@calexandru2018
Copy link
Contributor

We'll be releasing them (the ones missing and some new updates) next week :)

@calexandru2018
Copy link
Contributor

Tags have been pushed to all projects and will be getting new tags as we release new versions, thank you all for your patience :)

@proletarius101
Copy link

@calexandru2018 I found that the tags of https://github.com/ProtonVPN/python-proton-vpn-logger might not be updated

proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Mar 4, 2024
Given that ProtonVPN/python-proton-vpn-api-core#1 (comment) is resolved.

A gotcha is that `python-proton-vpn-logger`'s tags seems not to be updated.
proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Mar 4, 2024
Given that ProtonVPN/python-proton-vpn-api-core#1 (comment) is resolved.

A gotcha is that `python-proton-vpn-logger`'s tags seems not to be updated.
@calexandru2018
Copy link
Contributor

Done @proletarius101 thanks for noticing it

proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Mar 4, 2024
Given that ProtonVPN/python-proton-vpn-api-core#1 (comment) is resolved.

A gotcha is that `python-proton-vpn-logger`'s tags seems not to be updated.
proletarius101 added a commit to flathub/com.protonvpn.www that referenced this issue Mar 5, 2024
Given that ProtonVPN/python-proton-vpn-api-core#1 (comment) is resolved.

A gotcha is that `python-proton-vpn-logger`'s tags seems not to be updated.
@proletarius101
Copy link

Hi @calexandru2018 . The tag in https://github.com/ProtonVPN/python-proton-keyring-linux-secretservice seems to be removed again. Can you please look into it?

@calexandru2018
Copy link
Contributor

@proletarius101 fixed sorry it was an old tag that did not get saved. Everything should be ok now and no other issues with this should be occuring, thanks for raising it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants