test(strings): lint strings files

Introduces an extra job to the linting stage, which uses swiftlint to
validate Localizable.strings files in the Strings package.

.gitlab-ci.yml

@@ -73,7 +73,6 @@ linting:commit-quality:
 linting:code-quality:
  extends:
  - .mr_job_template
- - .ios_job_template
  stage: linting
  artifacts:
  paths:
@@ -82,6 +81,18 @@ linting:code-quality:
  codequality: codequality_report.json
  script: 
  - scripts/code_quality.sh
+ tags:
+ - iOS_vpn 
+ rules:
+
+linting:strings-files:
+ extends:
+ - .mr_job_template
+ stage: linting
+ script:
+ - scripts/lint_translations.sh
+ tags:
+ - macOS_vpn
  rules:
 
 # Reenable when/if we have a license

Mintfile

@@ -0,0 +1 @@
+realm/[email protected]

libraries/Strings/.swiftlint.yml

@@ -0,0 +1,15 @@
+only_rules:
+ - custom_rules
+
+included: doesn't seem to work, so these input files have to be passed during the swiftlint invocation
+ - Sources/Strings/Resources/*/Localizable.strings
+
+custom_rules:
+ malformed_entry:
+ regex: '^(?!($|(\/\* [^\n]* \*\/$)|(\"[^\n]*\" = \"[^\n]*\";$)|(\/\/)))'
+ message: "Each line should be either a comment or translation"
+ severity: error
+ leaky_block_comment:
+ regex: '^\/\*[^\n]*\*\/[^\n]'
+ message: "Block comments should not have any characters after the closing brace"
+ severity: error

scripts/lint_translations.sh

@@ -0,0 +1,2 @@
+mint run swiftlint --config libraries/Strings/.swiftlint.yml libraries/Strings/Sources/Strings/Resources/*.lproj/Localizable.strings
+