Refactor pub/sub to localize events #921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the event system in Mirador so that instead of publishing/subscribing to the global
jQuery
object, events are published/subscribed to an instance ofMirador.EventEmitter
that belongs toMirador
. This is a first step to making it possible to have multiple instances of Mirador on the page (i.e. #904).This PR touches quite a few source files in the
release2.1
branch:@rsinghal @aeschylus Not sure if you guys already started this on your own or not, so I figured I'd finish what I started last week and throw this up here for you to take a look at.