[feat] 웨이팅화면 UI 구현 #207
Merged
[feat] 웨이팅화면 UI 구현 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release v0.1.0
release v0.1.1
release v0.1.2
release v0.1.3
release v1.0.4
release v0.1.7
release v1.0.1
release v1.0.2
release v1.0.3
release v1.0.4
release v1.0.5
release v1.0.6
release v1.0.7
wjdtkdgns777
added
enhancement
|
UI 구현 PR 의 경우 스크린샷이 있으면 좋을 것 같아요 PR 양식에 따로 설정해두진 않았지만 |
|
다른 화면에서 처럼 Composable 함수 내에서 필요한 파라미터를 하나씩 작성하고, 개행 하는 식으로 수정, Modifier 에 설정값이 한개 뿐일 경우엔 같은 라인에 작성하는 정도만 수정하면 딱히 문제 될 부분이 없어보입니다. 연관된 부분들 수정해주시고 merge 하면 될 것 같습니다. 수고하셨습니다 |
easyhooon
reviewed
Jun 1, 2024
| } | ||
|
|
||
| @Composable | ||
| fun WaitInfoCard(location: String, order: Int, waitingNumber: Int, people: Int) { |
There was a problem hiding this comment.
파라미터들을 하나씩 이전에 작성한 다른 컴포저블 함수들 처럼 개행해주세여
easyhooon
reviewed
Jun 1, 2024
| Icon( | ||
| imageVector = ImageVector.vectorResource(id = R.drawable.ic_arrow_below_waiting), | ||
| contentDescription = "filter icon", | ||
| modifier = Modifier |
There was a problem hiding this comment.
Suggested change
| modifier = Modifier | |
| modifier = Modifier.align(Alignment.CenterVertically), |
easyhooon
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
웨이팅화면의 UI 들과 간략하게 모듈틀을 작성해뒀습니다.
부스 상세화면의 다이얼로그 2개와 웨이팅화면의 UI가 포함됩니다.
UI쪽만 작성한 부분이고 수정 사항이 계속 생기는듯하여 일단은 string을 빼두거나 하진 않았습니다