add alpine dockerfile #6958
add alpine dockerfile #6958
Conversation
| DOCKER_BUILD="docker build --build-arg BUILD_CONCURRENCY=${CONCURRENCY} --build-arg DOCKER_TAG=${DOCKER_TAG:?unset} -t ${IMAGE_NAME:?unset} -f" | ||
|
|
||
| $DOCKER_BUILD Dockerfile .. | ||
| $DOCKER_BUILD Dockerfile-alpine .. |
There was a problem hiding this comment.
Actually this file is not used anymore (at least as far as I understand).
During release we build images without using it, see:
Also we have this for CI:
In general IMO your PR is already very welcome and I am ready to merge it, but if you have some time would be great to also update these CI jobs (may be at least this one to make sure that this Alpine image is buildable after each PR).
There was a problem hiding this comment.
It's handy to have something around to remind you how to build it locally.
Maybe thats the reason why it's still around?
👍 I'll look into the CI jobs. Only built it locally so far.
There was a problem hiding this comment.
It seems until you merge at least one PR you will have to wait for my approval before running CI, so it will make feedback loop for you quite long... We can merge Dockerfile only first (and then add CI in separate PR) if it will be a problem - just let me know.
There was a problem hiding this comment.
Fine with me. I just removed the last commit with the workflow changes.
There was a problem hiding this comment.
Okay, I'll merge it soon, another option if it won't work: just debug it in your fork first....
Issue
#6956
Tasklist
Requirements / Relations
None