Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes the Resizing of button on Book Description page #127

Merged
merged 7 commits into from
Oct 7, 2021

Conversation

SanskarModi22
Copy link
Contributor

@SanskarModi22 SanskarModi22 commented Oct 6, 2021

Resized the buttons in the Book Description page #110

Description

Fixed the size of the buttons according to the screen and adjusted the scrolling on clicking Read More.
Fixes #110

Screenshots

Screenshot_1633499514

Screenshot_1633499517

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Test

Tested on 2 emulators

  • Pixel 3 XL
  • 2.7 QVGA

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

There are too many syntax errors on the book description page.
Resolve those, and do git pull upstream main before pushing your final changes.

Also, Exchange this book should only be visible when the book is not owned by the user.

Notify me once you make the respective changes

@SanskarModi22
Copy link
Contributor Author

I have removed the syntax errors . Please check it once . The errors were due to merge conflict.

@Mohitmadhav Mohitmadhav merged commit 940ed0c into Project-Easter:main Oct 7, 2021
@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 7, 2021
@Mohitmadhav
Copy link
Member

@SanskarModi22 I added the padding and made some minor changes.
Do git pull upstream main to get those changes.
And make sure to follow Linting rules from now onwards

@SanskarModi22
Copy link
Contributor Author

Ok.

@SanskarModi22 SanskarModi22 deleted the hactober/Sanskar branch October 15, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resize the buttons in the Book Description page
2 participants