Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting check (Remove Warnings) fix #148

Merged
merged 2 commits into from
Oct 31, 2021

Conversation

aryang117
Copy link
Contributor

@aryang117 aryang117 commented Oct 31, 2021

Description

This fixes multiple all linting issue/warning except:

  • All QuerySnapshot and QueryDocumentSnapshot warnings in database_service.dart as I don't know what kind of data is being received here
  • getImage being depricated, changing this may impact a lot of other things and therefore has been not been fixed (edit_profile.dart)
  • OwnerInfo class warning has not been fixed.

Fixes 32 of 47 warnings.

Fixes #99

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Mohitmadhav Mohitmadhav merged commit 131cb9a into Project-Easter:main Oct 31, 2021
@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting check (Remove Warnings)
2 participants